Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ensure global hidden attribute is honored for all components #5059

Merged
merged 10 commits into from
Aug 3, 2022
Merged

feat: ensure global hidden attribute is honored for all components #5059

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
08d8877
depricate active prop notice
Elijbet Jul 29, 2022
0fe57b9
feature(loader): phasing out active prop for global hidden attribute …
Elijbet Jul 30, 2022
06e2fa1
Merge branch 'master' into elijbet/3821-calcite-loader-drops-active-i…
Elijbet Jul 30, 2022
11cba83
ensure global hidden attribute is honored for all components
Elijbet Aug 1, 2022
64c663e
Merge branch 'master' into elijbet/3821-calcite-loader-drops-active-i…
Elijbet Aug 1, 2022
163fb98
ensure all chomponents use hidden test util
Elijbet Aug 1, 2022
6af2542
Merge branch 'master' into elijbet/3821-calcite-loader-drops-active-i…
Elijbet Aug 2, 2022
c23bad5
cleanup
Elijbet Aug 2, 2022
1996d0a
cleanup
Elijbet Aug 2, 2022
eed9168
typo
Elijbet Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/components/loader/loader.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,17 @@ $loader-circumference: ($loader-scale - (2 * $stroke-width)) * 3.14159;
}

:host {
@apply hidden;
}
visibility: hidden;

:host([active]) {
@apply flex;
&:host([hidden]) {
Elijbet marked this conversation as resolved.
Show resolved Hide resolved
visibility: hidden !important;
}
&:host:not([hidden]) {
@apply flex;
}
&:host([active]) {
@apply flex;
}
}

.loader__text {
Expand Down
7 changes: 6 additions & 1 deletion src/components/loader/loader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,12 @@ export class Loader {
// Properties
//
//--------------------------------------------------------------------------
/** When true, the component is active. */

/**
* When true, activates the loader
*
* @deprecated use global hidden attribute instead
*/
@Prop({ reflect: true }) active = false;

/** When true, displays smaller and appears to the left of the text. */
Expand Down