Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ensure global hidden attribute is honored for all components #5059

Merged
merged 10 commits into from
Aug 3, 2022
Merged

feat: ensure global hidden attribute is honored for all components #5059

merged 10 commits into from
Aug 3, 2022

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Jul 30, 2022 •
edited
Loading

Related Issue: #3821

Summary

Added support for the global hidden attribute for all components for behavior consistency.

Made sure all components use hidden test util.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Jul 30, 2022
@Elijbet Elijbet changed the title feature(loader): phasing out active prop in favor of global hidden attribute by giving the latter higher precedence feat(loader): phasing out active prop in favor of global hidden attribute by giving the latter higher precedence Jul 30, 2022
@Elijbet Elijbet requested review from jcfranco and removed request for jcfranco July 30, 2022 05:18
@Elijbet Elijbet changed the title feat(loader): phasing out active prop in favor of global hidden attribute by giving the latter higher precedence feat: ensure global hidden attribute is honored for all components Aug 1, 2022
@Elijbet Elijbet marked this pull request as ready for review August 1, 2022 23:34
@Elijbet Elijbet requested a review from a team as a code owner August 1, 2022 23:34
driskull
driskull approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 Looks good to me 👍

jcfranco
jcfranco approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from some comments, this LGTM! 🎉

src/components/accordion/accordion.e2e.ts Show resolved Hide resolved
src/components/input-date-picker/input-date-picker.e2e.ts Outdated Show resolved Hide resolved
src/components/radio-group-item/radio-group-item.e2e.ts Outdated Show resolved Hide resolved
src/components/tooltip/tooltip.e2e.ts Outdated Show resolved Hide resolved
@Elijbet Elijbet merged commit adcbb55 into master Aug 3, 2022
@Elijbet Elijbet deleted the elijbet/3821-calcite-loader-drops-active-in-favor-of-hidden branch August 3, 2022 00:20
@github-actions github-actions bot added this to the Sprint 07/25 - 08/05 milestone Aug 3, 2022
@Elijbet Elijbet mentioned this pull request Aug 7, 2022
Merged
@nwhittaker nwhittaker mentioned this pull request Aug 11, 2022
Closed
@jcfranco jcfranco mentioned this pull request Aug 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

@driskull driskull driskull approved these changes

Assignees

@Elijbet Elijbet

Labels
enhancement Issues tied to a new feature or request.
Projects
None yet
Milestone
Sprint 07/25 - 08/05
Development

Successfully merging this pull request may close these issues.
3 participants
@Elijbet @jcfranco @driskull