fix(panel): the panel is now dismissed on escape keydown and not keyu… #3657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p for consistency
driskull
pushed a commit
that referenced
this pull request
Dec 8, 2021
…p for consistency (#3657) Co-authored-by: Eliza Khachatryan <eli97736@esri.com>
driskull
added a commit
that referenced
this pull request
Dec 10, 2021
* refactor: Remove setting 'dir' attribute within components. #2079 * fix styles * fix screener? * cleanup * revert link changes * fix link * fix merge issue * alert, action-pad. * button * accordion-item * card * chip * color-picker, popper * combobox * combobox-item * combobox-item-group * popper test fix, dropdown * filter * fix test? * icon * alert, dropdown-item, link * input * input-message * label * modal * notice * move tile-select to use css logical props * update tab-title to use css logical props * update switch to use css logical props * update stepper-item to use css logical props * panel * pick-list-group, pick-list-item * block-section * popover * tree-item * rating * update select use css logical props * update shell-center-row to use css logical props * fix select styles * refactor(filter): enforce items prop via type (#3643) * fix(action-bar): Allow slotting tooltip after initialization (#3642) * fix(action-bar): Allow slotting tooltip after initialization. #3495 * review fixes * build(deps): bump @storybook/cli from 6.4.1 to 6.4.8 (#3638) Bumps [@storybook/cli](https://github.com/storybookjs/storybook/tree/HEAD/lib/cli) from 6.4.1 to 6.4.8. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.4.8/lib/cli) --- updated-dependencies: - dependency-name: "@storybook/cli" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 1.0.0-next.318 * build(deps): bump eslint from 8.3.0 to 8.4.1 (#3649) Bumps [eslint](https://github.com/eslint/eslint) from 8.3.0 to 8.4.1. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.3.0...v8.4.1) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump @esri/calcite-ui-icons from 3.17.6 to 3.17.8 (#3650) Bumps [@esri/calcite-ui-icons](https://github.com/Esri/calcite-ui-icons) from 3.17.6 to 3.17.8. - [Release notes](https://github.com/Esri/calcite-ui-icons/releases) - [Commits](Esri/calcite-ui-icons@v3.17.6...v3.17.8) --- updated-dependencies: - dependency-name: "@esri/calcite-ui-icons" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump @storybook/addon-docs from 6.4.1 to 6.4.8 (#3648) Bumps [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/addons/docs) from 6.4.1 to 6.4.8. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.4.8/addons/docs) --- updated-dependencies: - dependency-name: "@storybook/addon-docs" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump color from 4.0.2 to 4.1.0 (#3656) Bumps [color](https://github.com/Qix-/color) from 4.0.2 to 4.1.0. - [Release notes](https://github.com/Qix-/color/releases) - [Commits](Qix-/color@4.0.2...4.1.0) --- updated-dependencies: - dependency-name: color dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump @typescript-eslint/parser from 5.5.0 to 5.6.0 (#3655) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.5.0 to 5.6.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.6.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump @storybook/addon-a11y from 6.4.1 to 6.4.8 (#3654) Bumps [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/addons/a11y) from 6.4.1 to 6.4.8. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.4.8/addons/a11y) --- updated-dependencies: - dependency-name: "@storybook/addon-a11y" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: update component READMEs (#3652) Co-authored-by: jcfranco <jcfranco@users.noreply.github.com> * build(deps): bump ts-jest from 27.0.7 to 27.1.0 (#3647) Bumps [ts-jest](https://github.com/kulshekhar/ts-jest) from 27.0.7 to 27.1.0. - [Release notes](https://github.com/kulshekhar/ts-jest/releases) - [Changelog](https://github.com/kulshekhar/ts-jest/blob/main/CHANGELOG.md) - [Commits](kulshekhar/ts-jest@v27.0.7...v27.1.0) --- updated-dependencies: - dependency-name: ts-jest dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump @storybook/html from 6.4.1 to 6.4.8 (#3641) Bumps [@storybook/html](https://github.com/storybookjs/storybook/tree/HEAD/app/html) from 6.4.1 to 6.4.8. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.4.8/app/html) --- updated-dependencies: - dependency-name: "@storybook/html" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump prettier from 2.5.0 to 2.5.1 (#3658) Bumps [prettier](https://github.com/prettier/prettier) from 2.5.0 to 2.5.1. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@2.5.0...2.5.1) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(panel): the panel is now dismissed on escape keydown and not keyup for consistency (#3657) Co-authored-by: Eliza Khachatryan <eli97736@esri.com> * 1.0.0-next.319 * feat(input-time-picker)!: localization support for input-time-picker (#3354) * chore: fix linting issues (#3581) * 1.0.0-next.320 * make sure all values are grabbed from tailwind theme * first pass at date-picker-day using logical props * tidy up and add missing text logical prop * fix test * cleanup * remove getElementDir * cleanup stepper, switch * fix casing * fix link animation * clean up conventions * use consistent casing for default value * tidy up * review fixes * fix alert padding. * fix notice * screener test * Revert "screener test" This reverts commit 74c0233. * fix anim * revert link change * fix overlapping border styles from date-picker-day * fix test * fix story * fix test * split up border radius for range start/ends * simplify border radius? * put the 45% radius back. * revert Co-authored-by: JC Franco <jfranco@esri.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ben Elan <benelan@users.noreply.github.com> Co-authored-by: jcfranco <jcfranco@users.noreply.github.com> Co-authored-by: Eliza Khachatryan <elijbet@gmail.com> Co-authored-by: Eliza Khachatryan <eli97736@esri.com> Co-authored-by: Erik Harper <eharperdicianno@esri.com> Co-authored-by: Duc Phan <ptmdmusic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…p for consistency
Related Issue: #3500
Summary
Since other components like dropdown and combobox are closed on escape keydown, this needs to follow the same behavior for consistency and to make it simpler to stop propagation of keyup event in case we have a nested component that closes on keydown.