Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix linting issues #3581

Merged
merged 4 commits into from
Dec 8, 2021
Merged

Conversation

ptmdmusique
Copy link
Contributor

Related Issue: none

Summary

TS yells at some of the typing when I'm starting the dev server on Windows. This PR fixes those.

@ptmdmusique ptmdmusique requested a review from a team as a code owner November 29, 2021 23:37
@ptmdmusique
Copy link
Contributor Author

cc @paulcpederson does this seems like a valid forked PR ❓

@jcfranco jcfranco changed the title Duc11611/typing chore: fix linting issues Nov 29, 2021
@jcfranco
Copy link
Member

Thanks for the PR!

I wonder why these don't show up in our setup. @ptmdmusique Can you share more info about your configuration/environment?

@ptmdmusique
Copy link
Contributor Author

ptmdmusique commented Nov 29, 2021

Hmmm, this is my spec

OS: Windows 10
npm version: 8.1.0
node version: 16.13.0

What config are you looking for ❓ I think the only thing I did was clone the repo, npm i then npm start and it threw me a bunch of errors on this aspect. @paulcpederson fixed Tailwind build issue on Windows a few days ago too

@jcfranco
Copy link
Member

I think the info you've provided is a great help. Thanks!

@paulcpederson
Copy link
Member

@ptmdmusique nice, looks good to me.

@jcfranco I have no idea why other environments don't show these errors, but they do seem like valid errors...

@jcfranco
Copy link
Member

Oh, I forgot to ask earlier, can you share the list of errors you're seeing? Maybe linting and/or the Stencil build behaves differently based on the OS. cc @benelan

@ptmdmusique
Copy link
Contributor Author

Ah sorry forgot to include the log, here we go

[05:34.2]  http://localhost:3334/
[05:34.2]  build, calcite, dev mode, started ...
[05:34.8]  transpile started ...
[05:35.1]  transpile finished in 261 ms
[05:35.1]  copy started ...
[05:35.1]  generate hydrate app started ...
[05:35.1]  generate lazy started ...
[05:46.2]  copy finished (4599 files) in 11.12 s
[05:57.1]  generate lazy finished in 22.08 s
[06:08.1]  generate hydrate app finished in 33.01 s

[ ERROR ]  postcss: src/components/calcite-handle/calcite-handle.css, line: 82: src/components/calcite-handle/calcite-handle.css
           `@apply` cannot be used with `.` because `.` either cannot be found, or its actual definition includes a
           pseudo-selector like :hover, :active, etc. If you're sure that `.` exists, make sure that any `@import`
           statements are being properly processed *before* Tailwind CSS sees your CSS, as `@apply` can only be used
           for classes in the same CSS tree.

     L81:    --calcite-animation-timing: 300ms;
     L83:  }

[ ERROR ]  postcss: src/components/calcite-value-list-item/calcite-value-list-item.css, line: 92: src/components/calcite-value-list-item/calcite-value-list-item.css
           `@apply` cannot be used with `.` because `.` either cannot be found, or its actual definition includes a
           pseudo-selector like :hover, :active, etc. If you're sure that `.` exists, make sure that any `@import`
           statements are being properly processed *before* Tailwind CSS sees your CSS, as `@apply` can only be used
           for classes in the same CSS tree.

     L91:    animation-fill-mode: both;
     L93:    animation-duration: var(--calcite-animation-timing);

[ ERROR ]  postcss: src/components/calcite-panel/calcite-panel.css, line: 286: src/components/calcite-panel/calcite-panel.css
           `@apply` cannot be used with `.` because `.` either cannot be found, or its actual definition includes a
           pseudo-selector like :hover, :active, etc. If you're sure that `.` exists, make sure that any `@import`
           statements are being properly processed *before* Tailwind CSS sees your CSS, as `@apply` can only be used
           for classes in the same CSS tree.

    L285:  }

[ ERROR ]  postcss: src/components/calcite-input-message/calcite-input-message.css, line: 144: src/components/calcite-input-message/calcite-input-message.css
           `@apply` cannot be used with `.` because `.` either cannot be found, or its actual definition includes a
           pseudo-selector like :hover, :active, etc. If you're sure that `.` exists, make sure that any `@import`
           statements are being properly processed *before* Tailwind CSS sees your CSS, as `@apply` can only be used
           for classes in the same CSS tree.

    L145:  :host([hidden]) {

[ ERROR ]  postcss: src/components/calcite-shell/calcite-shell.css, line: 96: src/components/calcite-shell/calcite-shell.css
           `@apply` cannot be used with `.` because `.` either cannot be found, or its actual definition includes a
           pseudo-selector like :hover, :active, etc. If you're sure that `.` exists, make sure that any `@import`
           statements are being properly processed *before* Tailwind CSS sees your CSS, as `@apply` can only be used
           for classes in the same CSS tree.

     L95:  }

[ ERROR ]  postcss: src/components/calcite-stepper/calcite-stepper.css, line: 78: src/components/calcite-stepper/calcite-stepper.css
           `@apply` cannot be used with `.` because `.` either cannot be found, or its actual definition includes a
           pseudo-selector like :hover, :active, etc. If you're sure that `.` exists, make sure that any `@import`
           statements are being properly processed *before* Tailwind CSS sees your CSS, as `@apply` can only be used
           for classes in the same CSS tree.

     L77:  }
     L79:  :root {

[ ERROR ]  postcss: src/components/calcite-tip-manager/calcite-tip-manager.css, line: 137: src/components/calcite-tip-manager/calcite-tip-manager.css
           `@apply` cannot be used with `.` because `.` either cannot be found, or its actual definition includes a
           pseudo-selector like :hover, :active, etc. If you're sure that `.` exists, make sure that any `@import`
           statements are being properly processed *before* Tailwind CSS sees your CSS, as `@apply` can only be used
           for classes in the same CSS tree.

    L137:  :root {

[ ERROR ]  postcss: src/components/calcite-shell-center-row/calcite-shell-center-row.css, line: 89: src/components/calcite-shell-center-row/calcite-shell-center-row.css
           `@apply` cannot be used with `.` because `.` either cannot be found, or its actual definition includes a
           pseudo-selector like :hover, :active, etc. If you're sure that `.` exists, make sure that any `@import`
           statements are being properly processed *before* Tailwind CSS sees your CSS, as `@apply` can only be used
           for classes in the same CSS tree.

     L89:    opacity: 0;

[ ERROR ]  postcss: src/components/calcite-flow/calcite-flow.css, line: 89: src/components/calcite-flow/calcite-flow.css
           `@apply` cannot be used with `.` because `.` either cannot be found, or its actual definition includes a
           pseudo-selector like :hover, :active, etc. If you're sure that `.` exists, make sure that any `@import`
           statements are being properly processed *before* Tailwind CSS sees your CSS, as `@apply` can only be used
           for classes in the same CSS tree.

     L89:    opacity: 0;

[ ERROR ]  postcss: src/components/calcite-select/calcite-select.css, line: 206: src/components/calcite-select/calcite-select.css
           `@apply` cannot be used with `.` because `.` either cannot be found, or its actual definition includes a
           pseudo-selector like :hover, :active, etc. If you're sure that `.` exists, make sure that any `@import`
           statements are being properly processed *before* Tailwind CSS sees your CSS, as `@apply` can only be used
           for classes in the same CSS tree.

    L205:      items-stretch
    L207:      relative;

[06:08.1]  build failed, watching for changes... in 33.85 s

@ptmdmusique
Copy link
Contributor Author

I just noticed something weird. The error logs I posted above are only for scss files (which is solved by removing the trailing spaces) and the TS error only appears when I open the file (e.g.: shared-list-tests.ts for the non-existing JSEvalable import).

The TS errors used to also be reported in the npm start log but it doesn't seem to do it anymore. Maybe the build script has some problem ❓

@benelan
Copy link
Member

benelan commented Nov 30, 2021

If its just trailing spaces we can change an eslint rule for that. I also have a Windows machine so I will take a look

@ptmdmusique
Copy link
Contributor Author

@jcfranco 👋 sorry I'm not used to this kind of stuff yet, but it seems like the Semantic PR / semantic (pull_request) still fails even after you changed the title to the correct format ❓ Is there anything I can do to fix that

@benelan
Copy link
Member

benelan commented Dec 6, 2021

@ptmdmusique can you please try merging with master by commenting /merge master

@benelan
Copy link
Member

benelan commented Dec 6, 2021

I re-ran the semantic PR check and it passed, there may have been some issue with it updating due to the PR being from a fork.

@ptmdmusique
Copy link
Contributor Author

oh oops, I missed your latest message and merge from master, let's see what's the action results will be then

@paulcpederson
Copy link
Member

@benelan @jcfranco is this good to go?

@jcfranco
Copy link
Member

jcfranco commented Dec 8, 2021

I think we can merge this one without the Screener check since it's not introducing any visual changes.

@ptmdmusique Thanks for sharing the error messages! We'll look into why these errors/warnings aren't showing up consistently.

@jcfranco jcfranco merged commit 66fa687 into Esri:master Dec 8, 2021
driskull pushed a commit that referenced this pull request Dec 8, 2021
driskull added a commit that referenced this pull request Dec 10, 2021
* refactor: Remove setting 'dir' attribute within components. #2079

* fix styles

* fix screener?

* cleanup

* revert link changes

* fix link

* fix merge issue

* alert, action-pad.

* button

* accordion-item

* card

* chip

* color-picker, popper

* combobox

* combobox-item

* combobox-item-group

* popper test fix, dropdown

* filter

* fix test?

* icon

* alert, dropdown-item, link

* input

* input-message

* label

* modal

* notice

* move tile-select to use css logical props

* update tab-title to use css logical props

* update switch to use css logical props

* update stepper-item to use css logical props

* panel

* pick-list-group, pick-list-item

* block-section

* popover

* tree-item

* rating

* update select use css logical props

* update shell-center-row to use css logical props

* fix select styles

* refactor(filter): enforce items prop via type (#3643)

* fix(action-bar): Allow slotting tooltip after initialization (#3642)

* fix(action-bar): Allow slotting tooltip after initialization.  #3495

* review fixes

* build(deps): bump @storybook/cli from 6.4.1 to 6.4.8 (#3638)

Bumps [@storybook/cli](https://github.com/storybookjs/storybook/tree/HEAD/lib/cli) from 6.4.1 to 6.4.8.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.4.8/lib/cli)

---
updated-dependencies:
- dependency-name: "@storybook/cli"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 1.0.0-next.318

* build(deps): bump eslint from 8.3.0 to 8.4.1 (#3649)

Bumps [eslint](https://github.com/eslint/eslint) from 8.3.0 to 8.4.1.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.3.0...v8.4.1)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump @esri/calcite-ui-icons from 3.17.6 to 3.17.8 (#3650)

Bumps [@esri/calcite-ui-icons](https://github.com/Esri/calcite-ui-icons) from 3.17.6 to 3.17.8.
- [Release notes](https://github.com/Esri/calcite-ui-icons/releases)
- [Commits](Esri/calcite-ui-icons@v3.17.6...v3.17.8)

---
updated-dependencies:
- dependency-name: "@esri/calcite-ui-icons"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump @storybook/addon-docs from 6.4.1 to 6.4.8 (#3648)

Bumps [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/addons/docs) from 6.4.1 to 6.4.8.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.4.8/addons/docs)

---
updated-dependencies:
- dependency-name: "@storybook/addon-docs"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump color from 4.0.2 to 4.1.0 (#3656)

Bumps [color](https://github.com/Qix-/color) from 4.0.2 to 4.1.0.
- [Release notes](https://github.com/Qix-/color/releases)
- [Commits](Qix-/color@4.0.2...4.1.0)

---
updated-dependencies:
- dependency-name: color
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump @typescript-eslint/parser from 5.5.0 to 5.6.0 (#3655)

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.5.0 to 5.6.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.6.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump @storybook/addon-a11y from 6.4.1 to 6.4.8 (#3654)

Bumps [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/addons/a11y) from 6.4.1 to 6.4.8.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.4.8/addons/a11y)

---
updated-dependencies:
- dependency-name: "@storybook/addon-a11y"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* docs: update component READMEs (#3652)

Co-authored-by: jcfranco <jcfranco@users.noreply.github.com>

* build(deps): bump ts-jest from 27.0.7 to 27.1.0 (#3647)

Bumps [ts-jest](https://github.com/kulshekhar/ts-jest) from 27.0.7 to 27.1.0.
- [Release notes](https://github.com/kulshekhar/ts-jest/releases)
- [Changelog](https://github.com/kulshekhar/ts-jest/blob/main/CHANGELOG.md)
- [Commits](kulshekhar/ts-jest@v27.0.7...v27.1.0)

---
updated-dependencies:
- dependency-name: ts-jest
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump @storybook/html from 6.4.1 to 6.4.8 (#3641)

Bumps [@storybook/html](https://github.com/storybookjs/storybook/tree/HEAD/app/html) from 6.4.1 to 6.4.8.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.4.8/app/html)

---
updated-dependencies:
- dependency-name: "@storybook/html"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump prettier from 2.5.0 to 2.5.1 (#3658)

Bumps [prettier](https://github.com/prettier/prettier) from 2.5.0 to 2.5.1.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.5.0...2.5.1)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(panel): the panel is now dismissed on escape keydown and not keyup for consistency (#3657)

Co-authored-by: Eliza Khachatryan <eli97736@esri.com>

* 1.0.0-next.319

* feat(input-time-picker)!: localization support for input-time-picker (#3354)

* chore: fix linting issues (#3581)

* 1.0.0-next.320

* make sure all values are grabbed from tailwind theme

* first pass at date-picker-day using logical props

* tidy up and add missing text logical prop

* fix test

* cleanup

* remove getElementDir

* cleanup stepper, switch

* fix casing

* fix link animation

* clean up conventions

* use consistent casing for default value

* tidy up

* review fixes

* fix alert padding.

* fix notice

* screener test

* Revert "screener test"

This reverts commit 74c0233.

* fix anim

* revert link change

* fix overlapping border styles from date-picker-day

* fix test

* fix story

* fix test

* split up border radius for range start/ends

* simplify border radius?

* put the 45% radius back.

* revert

Co-authored-by: JC Franco <jfranco@esri.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ben Elan <benelan@users.noreply.github.com>
Co-authored-by: jcfranco <jcfranco@users.noreply.github.com>
Co-authored-by: Eliza Khachatryan <elijbet@gmail.com>
Co-authored-by: Eliza Khachatryan <eli97736@esri.com>
Co-authored-by: Erik Harper <eharperdicianno@esri.com>
Co-authored-by: Duc Phan <ptmdmusic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants