Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow global focus color token to inherit fallback value #11711

Merged
merged 1 commit into from
Mar 7, 2025
Merged

fix: allow global focus color token to inherit fallback value #11711

merged 1 commit into from
Mar 7, 2025

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Mar 7, 2025 •
edited
Loading

Related Issue: #11651

Summary

Removes the global focus color introduced in #10512 to match the behavior of the deprecated --calcite-ui-focus-color. Previously, --calcite-color-focus was defined at :root, preventing it from inheriting updates to --calcite-color-brand (its fallback).

This is not considered a breaking change because:

  • it only affects outputs that are not publicly documented
  • the default color will still be applied as expected
  • --calcite-color-focus remains available for overriding the focus color

Note: #11713 will restore --calcite-color-focus after #11391 lands.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Mar 7, 2025
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Mar 7, 2025
@jcfranco jcfranco mentioned this pull request Mar 7, 2025
Open
6 tasks
@jcfranco jcfranco marked this pull request as ready for review March 7, 2025 17:05
@jcfranco jcfranco requested a review from alisonailea as a code owner March 7, 2025 17:05
@jcfranco jcfranco requested review from macandcheese and geospatialem and removed request for alisonailea March 7, 2025 17:05
macandcheese
macandcheese approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@macandcheese macandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - could we adjust the title or use "tooling", etc., so users don't get confused by this changelog entry and think the functionality is being removed?

@jcfranco
Copy link
Member Author

jcfranco commented Mar 7, 2025

@macandcheese Good idea. I'll revisit the title.

@jcfranco jcfranco changed the title fix: remove convenience global focus color token fix: allow global focus color token to inherit fallback value Mar 7, 2025
@jcfranco jcfranco merged commit f8c63e3 into dev Mar 7, 2025
23 checks passed
@jcfranco jcfranco deleted the jcfranco/10510-remove-convenience-focus-color-global-token branch March 7, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macandcheese macandcheese macandcheese approved these changes

@geospatialem geospatialem Awaiting requested review from geospatialem

Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2025-03-25 - 3.1.0 Mar Release
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @macandcheese