feat: add default focus color token #10512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geospatialem
reviewed
Oct 9, 2024
There was a problem hiding this comment.
@alisonailea Awesome! 💨 Can you also add in the more related #10510 to the issue context?
jcfranco
requested changes
Oct 18, 2024
There was a problem hiding this comment.
Do we need to generate separate semantic output for the default focus color to be added? This change is breaking as it removes exports from the global files (causing this build failure).
jcfranco
reviewed
Oct 18, 2024
jcfranco
reviewed
Oct 18, 2024
packages/calcite-design-tokens/support/tests/__snapshots__/index.spec.ts.snap
Show resolved
Hide resolved
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
jcfranco
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180 #10510
Summary
This adds
calcite-color-focusto replace the deprecatedcalcite-ui-focus-color