Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog, modal, popover, sheet): restore focusTrapDisabled reactiveness #11586

Merged
merged 2 commits into from
Feb 19, 2025
Merged

fix(dialog, modal, popover, sheet): restore focusTrapDisabled reactiveness #11586

merged 2 commits into from
Feb 19, 2025

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Feb 18, 2025 •
edited
Loading

Related Issue: #11527

Summary

This updates useFocusTrap to toggle the trap accordingly if focusTrapDisabled is modified at runtime.

Note: Testing for this and other controllers will be addressed in #11305 and #11558.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Feb 18, 2025
@jcfranco jcfranco requested a review from Elijbet February 19, 2025 00:01
@jcfranco jcfranco changed the title fix(dialog, modal, popover, sheet): restore focusTrapDisabled reactiveness fix(dialog, modal, popover, sheet): restore focusTrapDisabled reactiveness Feb 19, 2025
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 19, 2025
@jcfranco jcfranco requested a review from driskull February 19, 2025 00:03
driskull
driskull reviewed Feb 19, 2025
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good but some tests are failing it seems

@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 19, 2025
@jcfranco
Copy link
Member Author

@driskull Tests should be fixed in the next run. 🤞

@jcfranco jcfranco requested a review from driskull February 19, 2025 00:52
driskull
driskull approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 💯

@jcfranco jcfranco merged commit 87ceba4 into dev Feb 19, 2025
14 checks passed
@jcfranco jcfranco deleted the jcfranco/11527-restore-focusTrapDisabled-reactiveness branch February 19, 2025 07:13
@github-actions github-actions bot added this to the 2025-02-25 - Feb Milestone milestone Feb 19, 2025
benelan pushed a commit that referenced this pull request Feb 19, 2025
@jcfranco @benelan
fix(dialog, modal, popover, sheet): restore focusTrapDisabled react…
b7312c1 
…iveness (#11586)
benelan pushed a commit that referenced this pull request Feb 19, 2025
@jcfranco @benelan
fix(dialog, modal, popover, sheet): restore focusTrapDisabled react…
a32dd7e 
…iveness (#11586)
@calcite-admin calcite-admin mentioned this pull request Feb 19, 2025
Merged
benelan pushed a commit that referenced this pull request Feb 19, 2025
@calcite-admin
chore: release main (#11596)
0b0b89f 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 3.0.3</summary>

##
[3.0.3](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@3.0.2...@esri/calcite-components@3.0.3)
(2025-02-19)


### Bug Fixes

* **dialog, modal, popover, sheet:** Restore `focusTrapDisabled`
reactiveness
([#11586](#11586))
([a32dd7e](a32dd7e))
* **input-date-picker:** No longer close while navigating months with
chevron actions
([#11525](#11525))
([acf5824](acf5824))
* **slider:** Ensure histograms with non-zero min are displayed
correctly
([#11587](#11587))
([9bb32f6](9bb32f6))
* **tooltip:** Close tooltips on prevented pointer move events
([#11557](#11557))
([470df20](470df20))
</details>

<details><summary>@esri/calcite-components-react: 3.0.3</summary>

##
[3.0.3](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@3.0.2...@esri/calcite-components-react@3.0.3)
(2025-02-19)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 3.0.2 to 3.0.3
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
benelan pushed a commit that referenced this pull request Feb 19, 2025
@calcite-admin @benelan
chore: release main (#11596)
559e684 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 3.0.3</summary>

[3.0.3](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@3.0.2...@esri/calcite-components@3.0.3)
(2025-02-19)

* **dialog, modal, popover, sheet:** Restore `focusTrapDisabled`
reactiveness
([#11586](#11586))
([a32dd7e](a32dd7e))
* **input-date-picker:** No longer close while navigating months with
chevron actions
([#11525](#11525))
([acf5824](acf5824))
* **slider:** Ensure histograms with non-zero min are displayed
correctly
([#11587](#11587))
([9bb32f6](9bb32f6))
* **tooltip:** Close tooltips on prevented pointer move events
([#11557](#11557))
([470df20](470df20))
</details>

<details><summary>@esri/calcite-components-react: 3.0.3</summary>

[3.0.3](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@3.0.2...@esri/calcite-components-react@3.0.3)
(2025-02-19)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 3.0.2 to 3.0.3
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@benelan benelan mentioned this pull request Feb 19, 2025
Merged
benelan added a commit that referenced this pull request Feb 19, 2025
@benelan @calcite-admin
chore: release main (#11596)
5ca8878 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 3.0.3</summary>


[3.0.3](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@3.0.2...@esri/calcite-components@3.0.3)
(2025-02-19)

* **dialog, modal, popover, sheet:** Restore `focusTrapDisabled`
reactiveness
([#11586](#11586))

([a32dd7e](a32dd7e))
* **input-date-picker:** No longer close while navigating months with
chevron actions
([#11525](#11525))

([acf5824](acf5824))
* **slider:** Ensure histograms with non-zero min are displayed
correctly
([#11587](#11587))

([9bb32f6](9bb32f6))
* **tooltip:** Close tooltips on prevented pointer move events
([#11557](#11557))

([470df20](470df20))
</details>

<details><summary>@esri/calcite-components-react: 3.0.3</summary>


[3.0.3](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@3.0.2...@esri/calcite-components-react@3.0.3)
(2025-02-19)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 3.0.2 to 3.0.3
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See

[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Calcite Admin <calcite-admin@esri.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

@Elijbet Elijbet Awaiting requested review from Elijbet

Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
3.0.0 Patch - 2025-02-19
Development

Successfully merging this pull request may close these issues.
3 participants
@jcfranco @driskull @geospatialem