Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add focusTrap common test helper #11558

Open
jcfranco opened this issue Feb 14, 2025 · 0 comments
Open

Add focusTrap common test helper #11558

jcfranco opened this issue Feb 14, 2025 · 0 comments
Labels
0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. p - medium Issue is non core or affecting less that 60% of people using the library tooling Issues relating to build system fixes or improvements.

Comments

@jcfranco
Copy link
Member

Priority impact

p - medium

Summary

We have a few focus-trapping component, so we need to introduce a test helper that will allow quick and easy test setup for this feature.

Desired Outcome

Add a focusTrap test helper to our common tests directory and apply it to the following components:

  • dialog
  • input-date-picker
  • input-time-picker (might not be applicable since this uses internal popover)
  • modal
  • popover
  • sheet

Resources

No response
@jcfranco jcfranco added 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. tooling Issues relating to build system fixes or improvements. labels Feb 14, 2025
@github-actions github-actions bot added the p - medium Issue is non core or affecting less that 60% of people using the library label Feb 14, 2025
This was referenced Feb 14, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. p - medium Issue is non core or affecting less that 60% of people using the library tooling Issues relating to build system fixes or improvements.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcfranco