Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(segmented-control-item): enhance component's interactivity states #11477

Merged
merged 1 commit into from
Feb 13, 2025
Merged

feat(segmented-control-item): enhance component's interactivity states #11477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ages/calcite-components/src/components/segmented-control-item/segmented-control-item.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
:host(:focus) {
@apply focus-inset;
outline-offset: -1px;
z-index: 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aPreciado88 Can you use the --calcite-z-index token here? We want to make sure all z-indices use our predefined layers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcfranco I'll update this, can I re use #10013 or should I create a new issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can reference #10013 since this would be a follow-up refactor.

}

.label--scale-s {
Expand Down
Loading