feat(segmented-control-item): enhance component's interactivity states #11477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
reviewed
Feb 14, 2025
| @@ -45,6 +45,7 @@ | |||
| :host(:focus) { | |||
| @apply focus-inset; | |||
| outline-offset: -1px; | |||
| z-index: 1; | |||
There was a problem hiding this comment.
@aPreciado88 Can you use the --calcite-z-index token here? We want to make sure all z-indices use our predefined layers.
There was a problem hiding this comment.
You can reference #10013 since this would be a follow-up refactor.
benelan
added a commit
that referenced
this pull request
Feb 17, 2025
* origin/dev: (171 commits) chore(tip-manager): drop empty spec test (#11568) chore: release next feat(chip): enhance component's interactivity states (#11538) chore: release next fix(tooltip): close tooltips on prevented pointer move events (#11557) chore: release main (#11561) chore: release next revert: build(deps): update arcgis to ^4.33.0-next.13 (#11539) (#11559) fix(dialog, modal, popover, sheet): fixes an issue that caused extra containers to be lost after internal trap updates (#11556) chore: release main (#11551) build(deps): update arcgis to ^4.33.0-next.13 (#11539) chore: release next fix(input-date-picker): allow navigating between months using chevron actions in Safari (#11547) chore: release next fix(dialog, modal, sheet): preserve focus-trap extra containers across internal trap updates (#11548) chore: release next feat(segmented-control-item): enhance component's interactivity states (#11477) chore: release next refactor: drop deprecated loadable component utilities (#11479) docs: link to package readmes from root readme (#11531) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10013
Summary
Update focus ring
z-indexto sit on top of border container.