Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): include groups in filtering #10511

Merged
merged 12 commits into from
Oct 31, 2024
+83 −14
Merged

fix(combobox): include groups in filtering #10511

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9669a40
fix(combobox): include groups in filtering
anveshmekala Oct 9, 2024
41e4deb
add test
anveshmekala Oct 10, 2024
3959c0a
Merge branch 'dev' into anveshmekala/7702-fix-comobox-filtering-groups
anveshmekala Oct 10, 2024
92597ee
fix build error
anveshmekala Oct 10, 2024
03feb0a
include groups in filtering for list
anveshmekala Oct 14, 2024
f14c04c
Merge branch 'dev' into anveshmekala/7702-fix-comobox-filtering-groups
anveshmekala Oct 14, 2024
2e9466c
add tests
anveshmekala Oct 14, 2024
2133c75
remove list related changes
anveshmekala Oct 31, 2024
e5ce537
Merge branch 'dev' into anveshmekala/7702-fix-comobox-filtering-groups
anveshmekala Oct 31, 2024
1c1a137
revert stylelint changes
anveshmekala Oct 31, 2024
1f2ff6c
refactor
anveshmekala Oct 31, 2024
30fb273
improve consistency
anveshmekala Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
Merge branch 'dev' into anveshmekala/7702-fix-comobox-filtering-groups
@anveshmekala
anveshmekala committed Oct 31, 2024
commit e5ce5378d60f3bef61b26d026424b094158f6b30
8 changes: 1 addition & 7 deletions packages/calcite-components/.stylelintrc.cjs
View file
Original file line number Diff line number Diff line change
@@ -1,13 +1,7 @@
// @ts-check

// ⚠️ AUTO-GENERATED CODE - DO NOT EDIT
const customFunctions = [
"get-trailing-text-input-padding",
"medium-modular-scale",
"modular-scale",
"scale-duration",
"small-modular-scale"
];
const customFunctions = [];
// ⚠️ END OF AUTO-GENERATED CODE

const scssPatternRules = [
22 changes: 6 additions & 16 deletions packages/calcite-components/src/components.d.ts
View file
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@
* It contains typing information for all components that exist in this project.
*/
import { HTMLStencilElement, JSXBase } from "@stencil/core/internal";
import { Alignment, Appearance, CollapseDirection, FlipContext, IconType, unknown as InteractionMode, Kind, Layout, LogicalFlowPosition, Position, Scale, SelectionAppearance as SelectionAppearance1, SelectionMode, Status, Width } from "./components/interfaces";
import { Alignment, Appearance, CollapseDirection, FlipContext, IconType, InteractionMode, Kind, Layout, LogicalFlowPosition, Position, Scale, SelectionAppearance as SelectionAppearance1, SelectionMode, Status, Width } from "./components/interfaces";
import { RequestedItem } from "./components/accordion/interfaces";
import { IconNameOrString } from "./components/icon/interfaces";
import { RequestedItem as RequestedItem1 } from "./components/accordion-item/interfaces";
@@ -35,8 +35,8 @@ import { ColorPickerMessages } from "./components/color-picker/assets/color-pick
import { ComboboxChildElement, SelectionDisplay } from "./components/combobox/interfaces";
import { ComboboxMessages } from "./components/combobox/assets/combobox/t9n";
import { DatePickerMessages } from "./components/date-picker/assets/date-picker/t9n";
import { DateLocaleData } from "./components/date-picker/utils";
import { HoverRange } from "./utils/date";
import { DateLocaleData } from "./components/date-picker/utils";
import { DialogMessages } from "./components/dialog/assets/dialog/t9n";
import { DialogPlacement } from "./components/dialog/interfaces";
import { RequestedItem as RequestedItem2 } from "./components/dropdown-group/interfaces";
@@ -61,6 +61,7 @@ import { ListDragDetail } from "./components/list/interfaces";
import { ItemData } from "./components/list-item/interfaces";
import { ListMessages } from "./components/list/assets/list/t9n";
import { SelectionAppearance } from "./components/list/resources";
import { MoveEventDetail, MoveTo, ReorderEventDetail } from "./components/sort-handle/interfaces";
import { ListItemMessages } from "./components/list-item/assets/list-item/t9n";
import { MenuMessages } from "./components/menu/assets/menu/t9n";
import { MenuItemMessages } from "./components/menu-item/assets/menu-item/t9n";
@@ -70,9 +71,6 @@ import { ModalMessages } from "./components/modal/assets/modal/t9n";
import { NoticeMessages } from "./components/notice/assets/notice/t9n";
import { PaginationMessages } from "./components/pagination/assets/pagination/t9n";
import { PanelMessages } from "./components/panel/assets/panel/t9n";
import { ItemData as ItemData1, ListFocusId } from "./components/pick-list/shared-list-logic";
import { ICON_TYPES } from "./components/pick-list/resources";
import { PickListItemMessages } from "./components/pick-list-item/assets/pick-list-item/t9n";
import { PopoverMessages } from "./components/popover/assets/popover/t9n";
import { RatingMessages } from "./components/rating/assets/rating/t9n";
import { ScrimMessages } from "./components/scrim/assets/scrim/t9n";
@@ -81,7 +79,6 @@ import { DisplayMode as DisplayMode1 } from "./components/shell-panel/interfaces
import { ShellPanelMessages } from "./components/shell-panel/assets/shell-panel/t9n";
import { FlipPlacement as FlipPlacement1, MenuPlacement as MenuPlacement1, OverlayPositioning as OverlayPositioning1 } from "./components";
import { SortHandleMessages } from "./components/sort-handle/assets/sort-handle/t9n";
import { MoveEventDetail, MoveTo, ReorderEventDetail } from "./components/sort-handle/interfaces";
import { DragDetail } from "./utils/sortableComponent";
import { StepperItemChangeEventDetail, StepperItemEventDetail, StepperItemKeyEventDetail, StepperLayout } from "./components/stepper/interfaces";
import { StepperMessages } from "./components/stepper/assets/stepper/t9n";
@@ -101,9 +98,7 @@ import { TileSelectGroupLayout } from "./components/tile-select-group/interfaces
import { TipMessages } from "./components/tip/assets/tip/t9n";
import { TipManagerMessages } from "./components/tip-manager/assets/tip-manager/t9n";
import { TreeItemSelectDetail } from "./components/tree-item/interfaces";
import { ValueListMessages } from "./components/value-list/assets/value-list/t9n";
import { ListItemAndHandle } from "./components/value-list-item/interfaces";
export { Alignment, Appearance, CollapseDirection, FlipContext, IconType, unknown as InteractionMode, Kind, Layout, LogicalFlowPosition, Position, Scale, SelectionAppearance as SelectionAppearance1, SelectionMode, Status, Width } from "./components/interfaces";
export { Alignment, Appearance, CollapseDirection, FlipContext, IconType, InteractionMode, Kind, Layout, LogicalFlowPosition, Position, Scale, SelectionAppearance as SelectionAppearance1, SelectionMode, Status, Width } from "./components/interfaces";
export { RequestedItem } from "./components/accordion/interfaces";
export { IconNameOrString } from "./components/icon/interfaces";
export { RequestedItem as RequestedItem1 } from "./components/accordion-item/interfaces";
@@ -133,8 +128,8 @@ export { ColorPickerMessages } from "./components/color-picker/assets/color-pick
export { ComboboxChildElement, SelectionDisplay } from "./components/combobox/interfaces";
export { ComboboxMessages } from "./components/combobox/assets/combobox/t9n";
export { DatePickerMessages } from "./components/date-picker/assets/date-picker/t9n";
export { DateLocaleData } from "./components/date-picker/utils";
export { HoverRange } from "./utils/date";
export { DateLocaleData } from "./components/date-picker/utils";
export { DialogMessages } from "./components/dialog/assets/dialog/t9n";
export { DialogPlacement } from "./components/dialog/interfaces";
export { RequestedItem as RequestedItem2 } from "./components/dropdown-group/interfaces";
@@ -159,6 +154,7 @@ export { ListDragDetail } from "./components/list/interfaces";
export { ItemData } from "./components/list-item/interfaces";
export { ListMessages } from "./components/list/assets/list/t9n";
export { SelectionAppearance } from "./components/list/resources";
export { MoveEventDetail, MoveTo, ReorderEventDetail } from "./components/sort-handle/interfaces";
export { ListItemMessages } from "./components/list-item/assets/list-item/t9n";
export { MenuMessages } from "./components/menu/assets/menu/t9n";
export { MenuItemMessages } from "./components/menu-item/assets/menu-item/t9n";
@@ -168,9 +164,6 @@ export { ModalMessages } from "./components/modal/assets/modal/t9n";
export { NoticeMessages } from "./components/notice/assets/notice/t9n";
export { PaginationMessages } from "./components/pagination/assets/pagination/t9n";
export { PanelMessages } from "./components/panel/assets/panel/t9n";
export { ItemData as ItemData1, ListFocusId } from "./components/pick-list/shared-list-logic";
export { ICON_TYPES } from "./components/pick-list/resources";
export { PickListItemMessages } from "./components/pick-list-item/assets/pick-list-item/t9n";
export { PopoverMessages } from "./components/popover/assets/popover/t9n";
export { RatingMessages } from "./components/rating/assets/rating/t9n";
export { ScrimMessages } from "./components/scrim/assets/scrim/t9n";
@@ -179,7 +172,6 @@ export { DisplayMode as DisplayMode1 } from "./components/shell-panel/interfaces
export { ShellPanelMessages } from "./components/shell-panel/assets/shell-panel/t9n";
export { FlipPlacement as FlipPlacement1, MenuPlacement as MenuPlacement1, OverlayPositioning as OverlayPositioning1 } from "./components";
export { SortHandleMessages } from "./components/sort-handle/assets/sort-handle/t9n";
export { MoveEventDetail, MoveTo, ReorderEventDetail } from "./components/sort-handle/interfaces";
export { DragDetail } from "./utils/sortableComponent";
export { StepperItemChangeEventDetail, StepperItemEventDetail, StepperItemKeyEventDetail, StepperLayout } from "./components/stepper/interfaces";
export { StepperMessages } from "./components/stepper/assets/stepper/t9n";
@@ -199,8 +191,6 @@ export { TileSelectGroupLayout } from "./components/tile-select-group/interfaces
export { TipMessages } from "./components/tip/assets/tip/t9n";
export { TipManagerMessages } from "./components/tip-manager/assets/tip-manager/t9n";
export { TreeItemSelectDetail } from "./components/tree-item/interfaces";
export { ValueListMessages } from "./components/value-list/assets/value-list/t9n";
export { ListItemAndHandle } from "./components/value-list-item/interfaces";
export namespace Components {
interface CalciteAccordion {
/**
You are viewing a condensed version of this merge commit. You can view the full changes here.