fix(combobox): include groups in filtering #10511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
jcfranco
approved these changes
Oct 31, 2024
| await page.waitForChanges(); | ||
| await combobox.type("group"); | ||
| await page.waitForChanges(); | ||
| await new Promise((res) => setTimeout(() => res(true), DEBOUNCE.filter)); |
There was a problem hiding this comment.
For consistency, can you use await page.waitForTimeout? Applies to other timeouts.
| await combobox.type("group"); | ||
| await page.waitForChanges(); | ||
| await new Promise((res) => setTimeout(() => res(true), DEBOUNCE.filter)); | ||
|
|
There was a problem hiding this comment.
Would waiting for calciteComboboxFilterChange help avoid the debounce timeout? We can revisit this separately.
There was a problem hiding this comment.
Agree a refactor PR would be beneficial considering it is repeated multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7702
Summary
Includes groups while filtering in
calcite-combobox.