Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content-start slot to Combobox Item #9322

Closed
2 of 6 tasks
yohannlouis opened this issue May 13, 2024 · 16 comments
Closed
2 of 6 tasks

Add content-start slot to Combobox Item #9322

yohannlouis opened this issue May 13, 2024 · 16 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Enterprise Issues logged by ArcGIS Enterprise team members ArcGIS Urban Issues logged by ArcGIS Urban team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library p2 - want for current milestone User set priority status of p2 - want for current milestone

Comments

@yohannlouis
Copy link

yohannlouis commented May 13, 2024

Check existing issues

Description

Allow custom icons to be used in the Calcite combo box. Currently this supports calcite icons only.

Acceptance Criteria

Allow custom icons to be used in the Calcite combo box.

Relevant Info

No response

Which Component

Combobox https://developers.arcgis.com/calcite-design-system/components/combobox/

Example Use Case

No response

Priority impact

p2 - want for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Enterprise

@yohannlouis yohannlouis added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels May 13, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone ArcGIS Enterprise Issues logged by ArcGIS Enterprise team members labels May 13, 2024
@macandcheese
Copy link
Contributor

This could be supported through ‘content-start / end’ slots.

@Anastasiia-Boleiko
Copy link

Anastasiia-Boleiko commented May 14, 2024

Could you please provide a link to the documentation? 😊
I couldn't locate the appropriate slot here 🙈.

Our use case: We need to use different icons including Calcite icons and custom icons.
Screenshot 2024-05-14 at 16 57 27

@macandcheese
Copy link
Contributor

Sorry for any confusion @Anastasiia-Boleiko - I meant adding these slots could be a potential way to support the request, it is not currently built in. :(

@Anastasiia-Boleiko
Copy link

Hi there,
Could you please clarify when approximately the ArcGIS Urban team can expect this feature to be implemented in Calcite? It is a much-needed feature in our app. 😊

@geospatialem geospatialem added the ArcGIS Urban Issues logged by ArcGIS Urban team members. label Jul 1, 2024
@Anastasiia-Boleiko
Copy link

For ArcGIS Urban the priority of this issue is different, since this is a super important feature for the upcoming release.

Priority impact
impact - p1 - need for current milestone

@ashetland ashetland added impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone and removed impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Jul 16, 2024
@macandcheese macandcheese changed the title Allow custom icons in Combobox Add content-start slot to Combobox Item Jul 16, 2024
@github-actions github-actions bot added the p2 - want for current milestone User set priority status of p2 - want for current milestone label Jul 16, 2024
@ashetland
Copy link
Contributor

Now that #3695 is complete, we should add a content-start slot.

@yohannlouis
Copy link
Author

Is there any timeline for this fix?

@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Sep 10, 2024
@geospatialem geospatialem added this to the 2024-12-17 - Dec Release milestone Sep 10, 2024
@geospatialem
Copy link
Member

@Anastasiia-Boleiko @yohannlouis Thanks for keeping this on our radar, Calcite is targeting December 2024 for implementation of the enhancement request to add the content-start slot.

@yohannlouis
Copy link
Author

@Anastasiia-Boleiko @yohannlouis Thanks for keeping this on our radar, Calcite is targeting December 2024 for implementation of the enhancement request to add the content-start slot.

Considering we're at the start of December, wanted to check if this is being worked on soon and if you can provide an estimated implementation date? We will plan our calcite UI work accordingly. Thanks!

@yohannlouis
Copy link
Author

Any update on this issue?

@ashetland ashetland added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Jan 9, 2025
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jan 9, 2025
@geospatialem
Copy link
Member

Any update on this issue?

@yohannlouis Thanks for the ping - the effort has been assigned and is targeted for the release later this month.

@yohannlouis
Copy link
Author

yohannlouis commented Jan 9, 2025

Any update on this issue?

@yohannlouis Thanks for the ping - the effort has been assigned and is targeted for the release later this month.

Thanks for the update. We have a UI re-design effort that is targeted end of this month too which is dependent on this calcite component enhancement. Would be perfect if we can have this fix ready by then. Sooner the better!

@macandcheese macandcheese added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jan 9, 2025
macandcheese added a commit that referenced this issue Jan 10, 2025
**Related Issue:** #9322 

## Summary
Adds support for `content-start` slot. @SkyeSeitz @ashetland can you
confirm the "kitchen sink" case spacing with icon prop, slotted content,
etc.
@macandcheese macandcheese added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jan 10, 2025
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 10, 2025
@geospatialem
Copy link
Member

Verified on the dev branch with the combobox-item's new "content-start" slot.

...
  <calcite-combobox-item selected icon="file-pdf" value="PDF" text-label="PDF">
    <calcite-icon icon="arrow-left" slot="content-start" scale="s"></calcite-icon>
    <calcite-icon icon="arrow-right" slot="content-end" scale="s"></calcite-icon>
  </calcite-combobox-item>...

@yohannlouis
Copy link
Author

Which version of calcite will contain this capabiltiy?

@geospatialem
Copy link
Member

Which version of calcite will contain this capabiltiy?

@yohannlouis The upcoming 3.0 breaking change release, targeted for delivery in the next few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Enterprise Issues logged by ArcGIS Enterprise team members ArcGIS Urban Issues logged by ArcGIS Urban team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library p2 - want for current milestone User set priority status of p2 - want for current milestone
Projects
None yet
Development

No branches or pull requests

8 participants