Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Combobox Item] - update selection icons #10580

Open
2 of 9 tasks
ashetland opened this issue Oct 22, 2024 · 1 comment
Open
2 of 9 tasks

[Combobox Item] - update selection icons #10580

ashetland opened this issue Oct 22, 2024 · 1 comment
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone ready for dev Issues ready for development implementation.
Milestone
2025-03-25 - 3.1....

Comments

@ashetland
Copy link
Contributor

ashetland commented Oct 22, 2024 •
edited
Loading

Check existing issues

Description

Now that Combobox Items have a description prop and slots for additional content (pr #9771, issue #9322), the selection icons should be updated to better serve more content-rich setups (see List (codepen) (also issue #9174 for single-select icons in List) and Table (codepen)).

Acceptance Criteria

  • Update single-select icon to circle (idle) / circle-inset-large (selected)
  • Update multiple-select icon to square (idle) / check-square-f (selected)
  • Idle icons should be color.border.input

Figma reference will all scales.

Before/after example:
CleanShot 2024-10-22 at 13 54 41@2x

Relevant Info

Should be implemented before or alongside issue #2311.

Which Component

Combobox Item

Example Use Case

No response

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@ashetland ashetland added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Oct 22, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Oct 22, 2024
@ashetland ashetland changed the title [Combobox Box Item] - update selection icons [Combobox Item] - update selection icons Oct 22, 2024
@ashetland ashetland added design Issues that need design consultation prior to development. ready for dev Issues ready for development implementation. labels Oct 22, 2024
@github-actions github-actions bot added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Oct 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@geospatialem geospatialem added this to the 2025-03-25 - Mar Release milestone Oct 22, 2024
@geospatialem geospatialem added estimate - 3 A day or two of work, likely requires updates to tests. and removed needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Oct 22, 2024
@ashetland ashetland mentioned this issue Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2025-03-25 - 3.1.0 Mar Release
Development

No branches or pull requests
2 participants
@geospatialem @ashetland