Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input Time Zone - selection defaults to first option in list when selecting offset with multiple signatures #8272

Closed
2 of 6 tasks
tayMAPNeil opened this issue Nov 28, 2023 · 3 comments
Closed
2 of 6 tasks

Input Time Zone - selection defaults to first option in list when selecting offset with multiple signatures #8272

tayMAPNeil opened this issue Nov 28, 2023 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-04-30 - Apr ...

Comments

@tayMAPNeil
Copy link

tayMAPNeil commented Nov 28, 2023 •
edited
Loading

Check existing issues

Actual Behavior

If you select a time zone that has multiple signatures with that offset, (e.g., GMT+10), the selected time zone will always fall back to the first option with that offset, even if it's not the one you've selected.

Expected Behavior

The selected time zone from the pick-list will be persisted in the time zone input.

Reproduction Sample

https://codepen.io/tmcneil/pen/JjxBQVL?editors=1000

Reproduction Steps

  1. Select input time zone component to select a time zone.
  2. Select (GMT+10) Brisbane and Lindeman from the list of available time zones.
  3. See that (GMT+10) Guam, Port Moresby, Saipan, and Truk is shown as the selected time zone.

Reproduction Version

1.11.0

Relevant Info

I can reproduce this on the sample in the developer documentation and in Map Viewer's Editor panel when selecting a time zone.

It is important to note that this issue is only reproducible when initially selecting a time zone. If you select a time zone and it defaults to the first time zone with that offset, selecting the time zone again will correctly display the chosen time zone in the component.

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

This is impacting the editing capabilities when adding or updating features in Map Viewer via the Editor panel. The chosen timezone is not being initially selected, and requires you to select it again to persist the correct time zone.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online
@tayMAPNeil tayMAPNeil added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Nov 28, 2023
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Online Issues logged by ArcGIS Online team members. p3 - want for upcoming milestone labels Nov 28, 2023
@geospatialem
Copy link
Member

Possibly related #8007 cc @jcfranco

@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Dec 11, 2023
@geospatialem geospatialem added this to the 2024-04-24 - Apr Release milestone Jan 10, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 10, 2024
@jcfranco jcfranco self-assigned this Apr 12, 2024
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Apr 12, 2024
@jcfranco jcfranco mentioned this issue Apr 16, 2024
Merged
jcfranco added a commit that referenced this issue Apr 18, 2024
@jcfranco
fix(input-time-zone): ensure selected item is properly displayed when…
1f94903 
… there are other items with the same offset (#9134)

**Related Issue:** #8272 

## Summary

This updates `input-time-zone` to also check for an item's label when
updating state to properly reflect user selection.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Apr 18, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Apr 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Apr 23, 2024
@geospatialem
Copy link
Member

Verified in 2.8.0-next.4 with https://codepen.io/tmcneil/pen/JjxBQVL

verify-time-zone-bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-04-30 - Apr Release
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @DitwanP @tayMAPNeil