Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[input-time-zone] updates items when related props are updated #8007

Closed
2 of 5 tasks
jcfranco opened this issue Oct 13, 2023 · 2 comments
Closed
2 of 5 tasks

[input-time-zone] updates items when related props are updated #8007

jcfranco opened this issue Oct 13, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2023 December Pri...

Comments

@jcfranco
Copy link
Member

Check existing issues

Actual Behavior

Changing any of the props that are used to generate the offset options recreate items but these are not rendered.

Expected Behavior

Changing lang, messageOverrides, mode or referenceDate updates and rerenders items.

Reproduction Sample

https://codepen.io/jcfranco/pen/QWzYOLe

Reproduction Steps

  1. look at applyTip and notice that the component needs to be recreated to pick up the updated options when rendering
  2. update the method to reuse the current component and notice that items will not update

Reproduction Version

1.9.2

Relevant Info

This line needs to be updated, so that the recreated items are used in rendering.

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@jcfranco jcfranco added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Oct 13, 2023
@github-actions github-actions bot added impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. labels Oct 13, 2023
@jcfranco jcfranco added estimate - 2 Small fix or update, may require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library and removed calcite-components Issues specific to the @esri/calcite-components package. labels Oct 13, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Nov 27, 2023
@geospatialem geospatialem added this to the 2023 December Priorities milestone Nov 27, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Nov 27, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Nov 27, 2023
@jcfranco jcfranco mentioned this issue Nov 28, 2023
Merged
@geospatialem geospatialem mentioned this issue Nov 28, 2023
Closed
6 tasks
jcfranco added a commit that referenced this issue Nov 30, 2023
@jcfranco
fix(input-time-zone): update time zone items when item-dependent prop…
f77532e 
…s change (#8271)

**Related Issue:** #8007

## Summary

This addresses an issue where `input-time-zone` was recreating time zone
groups when related props were modified, but these were not affecting
state, so the items would remain unchanged.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 30, 2023
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Nov 30, 2023
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 1, 2023
@geospatialem
Copy link
Member

Verified with 1.12.0-next.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2023 December Priorities
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @DitwanP