Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking a radio button label flashes focus on the group's first radio button #6698

Closed
nwhittaker opened this issue Mar 29, 2023 · 3 comments
Closed

Clicking a radio button label flashes focus on the group's first radio button #6698

nwhittaker opened this issue Mar 29, 2023 · 3 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Milestone
2023 June patch p...

Comments

@nwhittaker
Copy link
Contributor

nwhittaker commented Mar 29, 2023 •
edited by alisonailea
Loading

Actual Behavior

Given a radio button group with no descendants in focus, mouse down on any of the group's radio button labels except the first. While the mouse button is down, focus is given to the group's first radio button.

Screenshot 2023-03-29 at 12 12 15 PM

Expected Behavior

Given a radio button group with no descendants in focus, mouse down on any of the group's radio button labels except the first. While the mouse button is down, focus is given to the radio button associated with the label that the mouse is on top of.

Screenshot 2023-03-29 at 12 22 05 PM

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/radio-button-group/

Reproduction Steps

  1. Visit the doc site and scroll to the Sample section.
  2. Mouse down on the Bushes label and see focus is given to the Trees radio button instead of the Bushes radio button.

Reproduction Version

1.2.0-next.0

Relevant Info

macOS 13, Chrome 111.

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

Could lead to brief user confusion about what radio button they're actually clicking.

Esri team

ArcGIS Field Apps
@nwhittaker nwhittaker added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Mar 29, 2023
@github-actions github-actions bot added ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Mar 29, 2023
@anveshmekala anveshmekala mentioned this issue May 26, 2023
Merged
@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jun 1, 2023
@geospatialem
Copy link
Member

@anveshmekala What would you estimate the time needed to accomplish a fix for the above issue?

@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Jun 1, 2023
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 7, 2023
@github-actions github-actions bot assigned geospatialem and unassigned anveshmekala Jun 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Installed and assigned for verification.

anveshmekala added a commit that referenced this issue Jun 7, 2023
@anveshmekala
fix(radio-button-group): no longer focus first radio button on label …
4267b8c 
…click and adds `setFocus` method. (#7050)

**Related Issue:**  #6698

## Summary

This PR will remove the focus flash from the first
`calcite-radio-button` in group on label click

Additional enhancements:
- Adds `setFocus( )` method in `calcite-radio-button-group`
- Users will be able to select label text in chrome. #6357 

Note:
With this PR, `delegateFocus` is removed from
`calcite-radio-button-group` which is causing #6698. Because the
tabIndex is set to 0 for the first focusable element on page load to
enable keyboard navigation into the group it makes `delegateFocus` to
apply focus styles on the first focusable element when the user clicks
on the label (invokes .focus( )) resulting in the behavior mentioned in
the issue 6698. To resolve this, `delegateFocus` is removed and added
`setFocus( )` method.
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 26, 2023
@geospatialem
Copy link
Member

Verified with 1.5.0-next.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Projects
None yet
Milestone
2023 June patch priorities
Development

No branches or pull requests
3 participants
@nwhittaker @geospatialem @anveshmekala