Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to select label text in radio group #6357

Closed
nwhittaker opened this issue Jan 26, 2023 · 4 comments
Closed

Unable to select label text in radio group #6357

nwhittaker opened this issue Jan 26, 2023 · 4 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2023 June patch p...

Comments

@nwhittaker
Copy link
Contributor

nwhittaker commented Jan 26, 2023 •
edited by alisonailea
Loading

Actual Behavior

Hovering the text label of a inside a shows a text style cursor. Holding down the mouse button and dragging the label text does not select the text and does check the assoc. radio control when the mouse button is released.

Expected Behavior

Hovering the text label of a inside a shows an arrow cursor. Dragging the cursor across the text label does select the text and does not select the assoc. radio control.

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/radio-button-group/

Reproduction Steps

Visit the radio-button-group doc page and try to perform selections on the radio button labels.

Reproduction Version

1.0.3

Relevant Info

See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/radio for an example of the expected behavior.

Regression?

No response

Impact

Impact is to users who expect radio button labels to behave in the same way native radio button labels behave. A common use case might be to want to copy label text for some other use.

Esri team

ArcGIS Field Apps
@nwhittaker nwhittaker added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 26, 2023
@github-actions github-actions bot added the ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. label Jan 26, 2023
@geospatialem geospatialem added the research Issues that require more in-depth research or multiple team members to resolve or make decision. label Mar 30, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Mar 30, 2023
@geospatialem
Copy link
Member

Research will be conducted to determine feasibility/next steps in June.

@anveshmekala anveshmekala self-assigned this May 24, 2023
@anveshmekala anveshmekala mentioned this issue May 26, 2023
Merged
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels May 26, 2023
@anveshmekala anveshmekala added the 1 - assigned Issues that are assigned to a sprint and a team member. label Jun 5, 2023
@anveshmekala
Copy link
Contributor

Need to determine the focus behavior when the text is selected to solve this issue since focus and selection behavior is different in chrome/edge compared to safari/FF.

@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. labels Jun 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Installed and assigned for verification.

anveshmekala added a commit that referenced this issue Jun 7, 2023
@anveshmekala
fix(radio-button-group): no longer focus first radio button on label …
4267b8c 
…click and adds `setFocus` method. (#7050)

**Related Issue:**  #6698

## Summary

This PR will remove the focus flash from the first
`calcite-radio-button` in group on label click

Additional enhancements:
- Adds `setFocus( )` method in `calcite-radio-button-group`
- Users will be able to select label text in chrome. #6357 

Note:
With this PR, `delegateFocus` is removed from
`calcite-radio-button-group` which is causing #6698. Because the
tabIndex is set to 0 for the first focusable element on page load to
enable keyboard navigation into the group it makes `delegateFocus` to
apply focus styles on the first focusable element when the user clicks
on the label (invokes .focus( )) resulting in the behavior mentioned in
the issue 6698. To resolve this, `delegateFocus` is removed and added
`setFocus( )` method.
@jcfranco jcfranco added p - medium Issue is non core or affecting less that 60% of people using the library and removed research Issues that require more in-depth research or multiple team members to resolve or make decision. labels Jun 23, 2023
@jcfranco jcfranco added the estimate - 3 A day or two of work, likely requires updates to tests. label Jun 23, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 26, 2023
@geospatialem
Copy link
Member

Verified in FF, Edge and Chrome browsers with 1.5.0-next.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2023 June patch priorities
Development

No branches or pull requests
6 participants
@jcfranco @nwhittaker @alisonailea @geospatialem @benelan @anveshmekala