Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button neutral and outline uses wrong color for border #5331

Closed
asangma opened this issue Sep 15, 2022 · 7 comments
Closed

Button neutral and outline uses wrong color for border #5331

asangma opened this issue Sep 15, 2022 · 7 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2023 January Prio...

Comments

@asangma
Copy link
Contributor

asangma commented Sep 15, 2022 •
edited
Loading

Actual Behavior

When Button is appearance="outline" and color="neutral", the border color is set to foreground-3.

Expected Behavior

Border color should be border-1.

Reproduction Sample

https://codepen.io/mtb-alan/pen/vYjgrJE

Reproduction Steps

Inspect the button in the example.

Reproduction Version

latest

Relevant Info

No response

Regression?

No response
@asangma asangma added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 15, 2022
@asangma
Copy link
Contributor Author

asangma commented Sep 15, 2022

cc @ashetland

@asangma asangma closed this as completed Sep 15, 2022
@asangma asangma reopened this Sep 15, 2022
@asangma
Copy link
Contributor Author

asangma commented Sep 15, 2022

cc @macandcheese

@ashetland
Copy link
Contributor

ashetland commented Sep 15, 2022 •
edited
Loading

@asangma Sadly, the codepen is blank But I agree with this one.

@asangma
Copy link
Contributor Author

asangma commented Sep 15, 2022 •
edited
Loading

LOLz. I pasted the wrong url. Updated.

@macandcheese
Copy link
Contributor

👍 agreed

@geospatialem geospatialem added the p - low Issue is non core or affecting less that 10% of people using the library label Oct 12, 2022
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Oct 12, 2022
@Elijbet Elijbet added the estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. label Dec 2, 2022
@Elijbet Elijbet self-assigned this Dec 2, 2022
@Elijbet Elijbet mentioned this issue Jan 11, 2023
Merged
Elijbet added a commit that referenced this issue Jan 11, 2023
@Elijbet
fix(button): neutral and outline button now has correct border color (#…
24e6d32 
…6269)

**Related Issue:** #5331

## Summary
When `Button` is `appearance="outline"` and `color="neutral"`, the
border color is set to `borderColor.color.1`.
@Elijbet Elijbet added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Jan 11, 2023
@github-actions github-actions bot assigned geospatialem and unassigned Elijbet Jan 11, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 18, 2023
@geospatialem
Copy link
Member

Verified in next.727 with the following html:

  <calcite-button appearance="outline" kind="neutral">Test</calcite-button>

image

@ashetland ashetland mentioned this issue Jan 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2023 January Priorities
Development

No branches or pull requests
5 participants
@macandcheese @geospatialem @asangma @Elijbet @ashetland