Skip to content

Commit

Permalink
fix(button): neutral and outline button now has correct border color (#…
Browse files Browse the repository at this point in the history
…6269)

**Related Issue:** #5331

## Summary
When `Button` is `appearance="outline"` and `color="neutral"`, the
border color is set to `borderColor.color.1`.
  • Loading branch information
Elijbet authored Jan 11, 2023
1 parent 6253ef4 commit 24e6d32
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/components/button/button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@
button,
a {
@apply text-color-1 bg-transparent;
border-color: theme("backgroundColor.foreground.3");
border-color: theme("borderColor.color.1");
&:hover {
box-shadow: inset 0 0 0 1px var(--calcite-ui-foreground-3);
}
Expand Down
3 changes: 3 additions & 0 deletions src/components/button/button.stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -156,3 +156,6 @@ export const darkModeRTL_TestOnly = (): string => html`
`;

darkModeRTL_TestOnly.parameters = { modes: modesDarkDefault };

export const outlineNeutralBorderColor_TestOnly = (): string =>
html`<calcite-button appearance="outline" kind="neutral">Test</calcite-button>`;

0 comments on commit 24e6d32

Please sign in to comment.