Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addressed issue #814 #815

Merged
merged 3 commits into from
Jul 15, 2019
Merged

addressed issue #814 #815

merged 3 commits into from
Jul 15, 2019

Conversation

pbuttigieg
Copy link
Member

Merging in the first pass at glacial flows.

@pbuttigieg pbuttigieg requested review from rduerr and kaiiam July 3, 2019 15:00
@pbuttigieg pbuttigieg self-assigned this Jul 3, 2019
@pbuttigieg
Copy link
Member Author

Hi @rduerr @kaiiam this was a bit rushed during the summer school. Please allow a bit of time until I finalise this class.

kaiiam
kaiiam approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@kaiiam kaiiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glacial run looks good, looks like you also fixed up some axioms form suglacial volcano.

@pbuttigieg
Copy link
Member Author

Thanks @kaiiam merging

@pbuttigieg pbuttigieg merged commit 4033aee into master Jul 15, 2019
@pbuttigieg pbuttigieg deleted the issue-814 branch July 15, 2019 18:07
rduerr
rduerr reviewed Jul 15, 2019
View reviewed changes
Copy link
Contributor

@rduerr rduerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question: A Jokulhlaup is really an event, this is a process. How does ENVO handle events?

Even if this term is defined as a process is OK, I think a few more synonyms with spelling variations are needed. In particular, the non-umlaut version of Jokulhlaup

@pbuttigieg
Copy link
Member Author

A question: A Jokulhlaup is really an event, this is a process. How does ENVO handle events?

An Event is understood as a BFO:process. They have a start and stop, thus are temporally extended, which places them in the process branch.

Often, the differentia is that and event is a process that has been sped up from some base rate.

Even if this term is defined as a process is OK, I think a few more synonyms with spelling variations are needed. In particular, the non-umlaut version of Jokulhlaup

I'll add those, thanks!

pbuttigieg added a commit that referenced this pull request Jul 15, 2019
@pbuttigieg
residual edit for #815, #815 (review)
61b2193
@pbuttigieg
Copy link
Member Author

@rduerr also see #602

pbuttigieg added a commit that referenced this pull request Jul 17, 2019
@pbuttigieg
Merge pull request #819 from EnvironmentOntology/issue-801
d77c51f 
Thalassic qualities for #801 and supplemental edits on #815 and #818
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rduerr rduerr rduerr left review comments

@kaiiam kaiiam kaiiam approved these changes

Assignees

@pbuttigieg pbuttigieg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pbuttigieg @rduerr @kaiiam