Confirm delete #179
Merged
Confirm delete #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damnit I hate javascript.
Steve has gained an implement and an AoE fire power that uses the implement. An example ritual and an example NPC (Badgers are not in 4E as creatures, so do not have to worry about OGL issues) (Ritual costs are tricky to grab as the attribute dropdown gets cleared as soon as it's off a character) Feat that adds to fire attack and damage powers (to show on steves new fire power). Updated fighter weapon talents to have an effect to boost that attack. This can be done automatically for 2 Handed Weapons, alas 1 handed weapons need a custom variable, but at least we get a custom variable demo!
When adding equipment to token action HUD integration I was reminded that in order to get it working I had to poke some quite internal and knarly methods in 4E. Basically things that we would change, that would then break token hud, and we would have no idea why. So I refactored them all into the hooks.js object, which gives Token HUD a single place for when it needs to call any method on one of our objects. Especially as a lot of them the logic is actually in the sheet. This means they will at least show up in a usages search in VSCode/Webstorm etc... so we know if we change them to also update the calling method. Method signatures were made to be as standardised as possible with all relevant information, so hopefully if we ever change an implementation there is no need to change api.
Me implementing this now has nothing whatsoever to do with me entering all my players powers and accidently slipping the mouse from "edit" to "delete"
|
I kept meaning to do this, but I think I just never got around to it because I have yet to accidently delete anything! Lucky me, but bad on me for not implementing it sooner to save others. |
|
Basically with all the times I accidentally deleted it I imagined the
nightmare of letting my players loose on it and suddenly it moved up my
priority list!
…On Mon, 14 Feb 2022 at 22:36, EndlesNights ***@***.***> wrote:
Merged #179 <#179> into dev.
—
Reply to this email directly, view it on GitHub
<#179 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGBXG7AL6YAXBXYQ7NJWYWLU3F7XDANCNFSM5OHXGZ2Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Me implementing this now has nothing whatsoever to do with me entering all my players powers and accidently slipping the mouse from "edit" to "delete"
Configurable, On by default.