pay: Fix a crash when waitblockheight times out #4317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
approved these changes
Jan 7, 2021
Comment on lines
+3936
to
+3938
|
|
||
|
|
||
| def test_pay_waitblockheight_timeout(node_factory, bitcoind): |
There was a problem hiding this comment.
Please mark this xfail and unmark in next commit, to avoid breaking bisect?
|
ACK 2cd25fb |
We need to differentiate timeouts from other results, so make it recognizable.
Fixes ElementsProject#4309 Changelog-Fixed: pay: Fixed an issue where waiting for the blockchain height to sync could time out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would
plugin_err()if the call towaitblockheightin thecorresponding modifier timed out, instead of returning after
successful sync. We now catch that and terminate the payment on
timeout. Since we only react to errors containing a blockheight from
the last node, not being in sync is fatal for that payment.
Fixes #4269
Fixes #4309
Changelog-Fixed: pay: Fixed an issue where waiting for the blockchain height to sync could time out.