-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
waitblockheight timeout causes crash. #4309
Labels
Comments
cdecker
added a commit
to cdecker/lightning
that referenced
this issue
Jan 6, 2021
cdecker
added a commit
to cdecker/lightning
that referenced
this issue
Jan 6, 2021
Fixes ElementsProject#4309 Changelog-Fixed: pay: Fixed an issue where waiting for the blockchain height to sync could time out.
cdecker
added a commit
to cdecker/lightning
that referenced
this issue
Jan 6, 2021
cdecker
added a commit
to cdecker/lightning
that referenced
this issue
Jan 6, 2021
Fixes ElementsProject#4309 Changelog-Fixed: pay: Fixed an issue where waiting for the blockchain height to sync could time out.
cdecker
added a commit
to cdecker/lightning
that referenced
this issue
Jan 7, 2021
cdecker
added a commit
to cdecker/lightning
that referenced
this issue
Jan 7, 2021
Fixes ElementsProject#4309 Changelog-Fixed: pay: Fixed an issue where waiting for the blockchain height to sync could time out.
cdecker
added a commit
to cdecker/lightning
that referenced
this issue
Jan 7, 2021
cdecker
added a commit
to cdecker/lightning
that referenced
this issue
Jan 7, 2021
Fixes ElementsProject#4309 Changelog-Fixed: pay: Fixed an issue where waiting for the blockchain height to sync could time out.
cdecker
added a commit
to cdecker/lightning
that referenced
this issue
Jan 7, 2021
cdecker
added a commit
to cdecker/lightning
that referenced
this issue
Jan 7, 2021
Fixes ElementsProject#4309 Changelog-Fixed: pay: Fixed an issue where waiting for the blockchain height to sync could time out.
cdecker
added a commit
that referenced
this issue
Jan 8, 2021
cdecker
added a commit
that referenced
this issue
Jan 8, 2021
Fixes #4309 Changelog-Fixed: pay: Fixed an issue where waiting for the blockchain height to sync could time out.
vibhaa
pushed a commit
to spider-pcn/lightning
that referenced
this issue
Mar 24, 2021
vibhaa
pushed a commit
to spider-pcn/lightning
that referenced
this issue
Mar 24, 2021
Fixes ElementsProject#4309 Changelog-Fixed: pay: Fixed an issue where waiting for the blockchain height to sync could time out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue and Steps to Reproduce
If we send a payment with
pay
and the receiver return anincorrect_or_unknown_payment_details
with a fake height like 999999pay
will callwaitblockheight
, but since that block height won't be reached within the timeout window, it will crash with:Instead it should just abort the payment.
getinfo
outputThe text was updated successfully, but these errors were encountered: