Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error Upgrading database to new 22 release #5760

Closed
CMDRZOD opened this issue Nov 30, 2022 · 4 comments · Fixed by #5786
Closed

Error Upgrading database to new 22 release #5760

CMDRZOD opened this issue Nov 30, 2022 · 4 comments · Fixed by #5786
Assignees
@rustyrussell
Labels
db
Milestone
v22.11.1

Comments

@CMDRZOD
Copy link

CMDRZOD commented Nov 30, 2022

Added --database-upgrade=true to my clightning run command to allow the new version to start. After doing this I get this output:

2022-11-30T20:08:04.605Z INFO lightningd: Updating database from version 199 to 212
Converting channels.short_channel_id '607622x1712x0' gave 2 changes != 1?

After this clightning does not start.
My node:
https://1ml.com/node/02a20247f515d978cbf9e9ce6a4287b5931d724068b7b88bbaead6380db3dd8e9a/channels?order=newest
@rustyrussell
Copy link
Contributor

OK, it's totally safe to downgrade for now (since db did NOT get updated!) while I look at this...

@rustyrussell rustyrussell added this to the v23.02 milestone Nov 30, 2022
@rustyrussell rustyrussell self-assigned this Nov 30, 2022
@CMDRZOD
Copy link
Author

CMDRZOD commented Dec 1, 2022

Yes I immediately went back to 12.1 without an issue.

@rustyrussell rustyrussell modified the milestones: v23.02, v22.11.1 Dec 4, 2022
@rustyrussell
Copy link
Contributor

Hmm, OK, somehow your node has two channels with the same scid. That doesn't seem possible, but this is an ancient, closed channel.

I'll log at BROKEN level instead of aborting...

rustyrussell added a commit to rustyrussell/lightning that referenced this issue Dec 6, 2022
@rustyrussell
wallet: only log broken if we have duplicate scids in channels.
c6125aa 
This was reported, but the channel was closed.  So however we ended
up with a duplicate, we're no *worse* off than we were before migration?

Fixes: ElementsProject#5760
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell mentioned this issue Dec 6, 2022
Merged
@CMDRZOD
Copy link
Author

CMDRZOD commented Dec 6, 2022

Thank you! Will wait for next release to try again.

cdecker pushed a commit that referenced this issue Dec 6, 2022
@rustyrussell @cdecker
wallet: only log broken if we have duplicate scids in channels.
e778ebb 
This was reported, but the channel was closed.  So however we ended
up with a duplicate, we're no *worse* off than we were before migration?

Fixes: #5760
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@CMDRZOD CMDRZOD mentioned this issue Mar 6, 2023
Closed
ddustin pushed a commit to ddustin/lightning that referenced this issue Apr 11, 2023
@rustyrussell @ddustin
wallet: only log broken if we have duplicate scids in channels.
a7d01d8 
This was reported, but the channel was closed.  So however we ended
up with a duplicate, we're no *worse* off than we were before migration?

Fixes: ElementsProject#5760
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
ddustin pushed a commit to ddustin/lightning that referenced this issue May 12, 2023
@rustyrussell @ddustin
wallet: only log broken if we have duplicate scids in channels.
40d9696 
This was reported, but the channel was closed.  So however we ended
up with a duplicate, we're no *worse* off than we were before migration?

Fixes: ElementsProject#5760
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustyrussell rustyrussell

Labels
db
Projects
None yet
Milestone
v22.11.1
Development

Successfully merging a pull request may close this issue.

wallet: only log broken if we have duplicate scids in channels. rustyrussell/lightning
2 participants
@rustyrussell @CMDRZOD