Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23.02 Startup - Large Node - SCID issue #6063

Closed
CMDRZOD opened this issue Mar 5, 2023 · 4 comments · Fixed by #6071
Closed

23.02 Startup - Large Node - SCID issue #6063

CMDRZOD opened this issue Mar 5, 2023 · 4 comments · Fixed by #6071
Assignees
Labels
Milestone

Comments

@CMDRZOD
Copy link

CMDRZOD commented Mar 5, 2023

Hi there. I attempted to download and use the Ubuntu 20.04 binary for upgrading my node. After allowing the database upgrade I get the following error:

2023-03-05T15:59:37.873Z INFO    lightningd: Updating database from version 199 to 216
2023-03-05T16:00:09.433Z **BROKEN** lightningd: migrate_channels_scids_as_integers: converting channels.short_channel_id '607622x1712x0' gave 2 changes != 1!                                                                                   2023-03-05T16:00:09.434Z **BROKEN** lightningd: migrate_channels_scids_as_integers: converting channels.short_channel_id '607622x1712x0' gave 2 changes != 1!                                                                                   2023-03-05T16:00:09.435Z **BROKEN** lightningd: migrate_channels_scids_as_integers: converting channels.short_channel_id '607622x1712x1' gave 2 changes != 1!                                                                                   2023-03-05T16:00:09.436Z **BROKEN** lightningd: migrate_channels_scids_as_integers: converting channels.short_channel_id '607622x1712x1' gave 2 changes != 1!                                                                                   migrate_channels_scids_as_integers: only converted 694 of 690 scids!

Once this error occurs the startup of the node fails.
My node:
https://1ml.com/node/02a20247f515d978cbf9e9ce6a4287b5931d724068b7b88bbaead6380db3dd8e9a
Thanks

@CMDRZOD
Copy link
Author

CMDRZOD commented Mar 6, 2023

Looks like this is similar to my problem with the previous release:
#5760 (comment)

@vincenzopalazzo vincenzopalazzo added this to the v23.05 milestone Mar 6, 2023
@vincenzopalazzo vincenzopalazzo modified the milestones: v23.05, v23.02 Mar 6, 2023
@endothermicdev endothermicdev modified the milestones: v23.02, v23.02.1 Mar 6, 2023
@rustyrussell
Copy link
Contributor

rustyrussell commented Mar 6, 2023

Hmm, I suspect we're hitting the new fatal check, does this help?

diff --git a/wallet/db.c b/wallet/db.c
index 5a5a1c78f..ea2e2d067 100644
--- a/wallet/db.c
+++ b/wallet/db.c
@@ -1532,8 +1532,8 @@ static void migrate_channels_scids_as_integers(struct lightningd *ld,
 	}
 
 	if (changes != tal_count(scids))
-		fatal("migrate_channels_scids_as_integers: only converted %zu of %zu scids!",
-		      changes, tal_count(scids));
+		log_broken(ld->log, "migrate_channels_scids_as_integers: only converted %zu of %zu scids!",
+			   changes, tal_count(scids));
 
 	/* FIXME: We cannot use ->delete_columns to remove
 	 * short_channel_id, as other tables reference the channels

@CMDRZOD
Copy link
Author

CMDRZOD commented Mar 7, 2023

Currently attempting to compile from source with patch applied. Running into errors. This is why I wait for bin files from releases.
Building on Ubuntu 20.04 server with prerequisites installed:
cd external/libwally-core && ./tools/autogen.sh /bin/sh: 1: ./tools/autogen.sh: not found make: *** [external/Makefile:83: external/x86_64-linux-gnu/libwally-core-build/src/libwallycore.la] Error 127

@CMDRZOD
Copy link
Author

CMDRZOD commented Mar 7, 2023

Okay I pulled from git, had to disable rust to get this to build on Ubuntu 20.04. Can confirm changes allow my node to start up successfully. Thank you!
2023-03-07T20:28:43.795Z INFO lightningd: Updating database from version 199 to 216 2023-03-07T20:30:36.763Z **BROKEN** lightningd: migrate_channels_scids_as_integers: converting channels.short_channel_id '607622x1712x0' gave 2 changes != 1! 2023-03-07T20:30:36.764Z **BROKEN** lightningd: migrate_channels_scids_as_integers: converting channels.short_channel_id '607622x1712x0' gave 2 changes != 1! 2023-03-07T20:30:36.766Z **BROKEN** lightningd: migrate_channels_scids_as_integers: converting channels.short_channel_id '607622x1712x1' gave 2 changes != 1! 2023-03-07T20:30:36.767Z **BROKEN** lightningd: migrate_channels_scids_as_integers: converting channels.short_channel_id '607622x1712x1' gave 2 changes != 1! 2023-03-07T20:30:36.979Z **BROKEN** lightningd: migrate_channels_scids_as_integers: only converted 694 of 690 scids!

"version": "v23.02-6-gb5c6140-modded",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants