Add iFlight Commando8 ELRS PR fixed version2 #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagarinlg
reviewed
May 21, 2022
|
Tested the binary from this PR. None of the issues I've reported on the older PR #1902 |
|
I think we're finally there, as well as all changes from PR1902 have been successfully ported to this PR. |
7cfee58 to
29d1feb
Compare
There was a problem hiding this comment.
The changes for the radio firmware are now as expected and already reviewed (in #1902).
However, I had to rebase / squash commits to cleanup this mess. In future, I expect things to be already done this way.
Apart from that, the original code had support for Companion, which is not the case anymore, and thus missing.
Closed
pfeerick
approved these changes
Aug 8, 2022
Add iFlight Commando8 ELRS radio
Fix bug introduced in EdgeTX#1967 which only affects !defined(RTCLOCK) boards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add iFlight Commando8 ELRS PR fixed version2
PR1902 seems to be unfixable broken for some reason, so we started all over and integrated latest changes and corrections.
Sorry for this approach, I hope this will be OK now.
Companion files will be updated with another commit.
Based on the EdgeTX PR #1902
[edit: pfeerick]
To power on or off this radio, you double press and hold the power button.
To access DFU or bootloader, you press the left joystick down (not centre press) and then while holding that down, hold down the power button. After about a second, the battery indicator will start animating. If USB is connected, it will go into DFU mode. If not, the bootloader menu will be shown.
To access the USB (for storage, joystick mode), you need to press and hold the power button after plugging in the USB until the battery leds animate. On initial connect it appears to be in charge mode. If you want to disconnect and resume charging, press and hold the power button again until the animation stops.
[/end edit]