Add iFlight Commando8 #1902

XING-IF · 2022-04-26T07:38:27Z

Add iFlight Commando8 ELRS radio.
Based on the OpenTX PR #8905 with fixes.
opentx/opentx#8905

https://shop.iflight-rc.com/Commando-8-Radio-Transmitter-Pro1696

Add iFlight Commando8 ELRS radio

fixed error

pfeerick

This is looking a lot better than the original code I saw a few weeks ago :)

Because of the recent changes to the build system (#1736) the scripts in /tools will need updating.

companion/src/simulation/simulatorwidget.cpp

fixed code

radio/src/targets/common/arm/stm32/audio_dac_driver.cpp

XING-IF · 2022-04-26T10:32:13Z

This is looking a lot better than the original code I saw a few weeks ago :)

Because of the recent changes to the build system (#1736) the scripts in /tools will need updating.

ok, we'll check. thanks

.github/workflows/actions.yml

companion/src/firmwares/opentx/opentxinterface.cpp

radio/src/gui/128x64/model_setup.cpp

radio/src/targets/taranis/CMakeLists.txt

radio/src/targets/taranis/board.cpp

radio/src/targets/taranis/board.h

tools/build-companion-nightly.sh

several code fixes after suggestions in PR

XING-IF · 2022-04-28T04:33:30Z

All suggestions have been implemented and code should be fixed. We kindly ask for a re-review or further suggestions! Thanks guys

Since Commando8 is very similar to t8 architecture

radio/src/targets/common/arm/stm32/bootloader/boot.cpp

radio/src/gui/gui_common.cpp

requested fix

cleanup code

pfeerick · 2022-04-29T04:08:50Z

This is looking starting to look pretty good now. No more breaking of other builds and code is starting to look reasonably clean :)

@raphaelcoeffic What needs to be done to kick the FreeRTOS change, as I don't think that should be there?

XING-IF · 2022-04-29T06:11:44Z

seems like all checks passed, no broken builds neither

Add iFlight Commando8 ELRS radio

fixed error

fixed code

several code fixes after suggestions in PR

raphaelcoeffic · 2022-04-29T08:54:50Z

This is looking starting to look pretty good now. No more breaking of other builds and code is starting to look reasonably clean :)

@raphaelcoeffic What needs to be done to kick the FreeRTOS change, as I don't think that should be there?

Looks like this slipped in: I just rebased on main and edited the culprit to remove the FreeRTOS change.

...and should only be set for releases compiled by the manufacturer.

pfeerick · 2022-04-29T09:23:29Z

Thanks! :) So, back to review mode...

ok, Windows simulator is kinda funky...

I'm not that familiar with the Companion/QT side of things, but it looks like the image for each of the sections (top, bottom, left and right side) are expected to be the full size of that section, not part-of, hence the smaller images repeating.

pfeerick · 2022-04-29T09:38:57Z

@elecpower As the Companion whisperer, I defer to you for the Companion side of this :)

elecpower · 2022-04-29T10:58:34Z

Compiled branch and after a very quick check there are basic issues. So for starters Companion requires updated/checked:

board capabilities
firmware capabilities
isAvailable functions
radio profile default module
radio hardware settings
radio to radio conversions
reading opentx bin format
write yaml format
simulator graphic as per @pfeerick above
etc

raphaelcoeffic · 2022-04-29T12:24:50Z

@elecpower side note: there is no OpenTx binary format here. The radio is basically unsupported on OpenTx side.

XING-IF · 2022-04-29T12:26:28Z

@elecpower side note: there is no OpenTx binary format here. The radio is basically unsupported on OpenTx side.

The OpenTX PR would be opentx/opentx#8905 but is not yet through.

deadbytefpv · 2022-05-11T04:40:22Z

Switch Config doesn't seem to stick.
SA to SD goes back into "None" after each power-cycle.
Radio.YML have these set up though.

pfeerick · 2022-05-11T06:13:43Z

Mine arrived today, and I just flashed the latest PR build onto it. I initially got the 'None' setting for the switches (which I'm not so concerned about yet - will have to see what happens on a clean config - as it should be defaulting to correct setting if invalid), and then after setting them, it has stuck for several reboot cycles. Are you changing pages or exiting the radio setup menu before powering off the radio after setting them up?

deadbytefpv · 2022-05-11T06:46:15Z

Mine arrived today, and I just flashed the latest PR build onto it. I initially got the 'None' setting for the switches (which I'm not so concerned about yet - will have to see what happens on a clean config - as it should be defaulting to correct setting if invalid), and then after setting them, it has stuck for several reboot cycles. Are you changing pages or exiting the radio setup menu before powering off the radio after setting them up?

Yes. I've actually kept the radio turned on quite a while before turning it off to see if the settings will stick..
I've also tested with a clean sd card to perhaps refresh the configs, but it still happened (settings went back to None after a reboot).
Thanks for checking things out!

XING-IF · 2022-05-11T07:37:46Z

@pfeerick @deadbytefpv I just checked with iFlight. The radio was obviously shipped with a custom build from their drives which is different to the code of this PR. The firmware version is misleading and says "Built by EdgeTX" which should actually say "Built by iFlight" as of this point the code was not merged yet. There were some fixes on their drive which have not been provided for this PR. I'm just trying to get some answers who fu**ed up again...

pfeerick · 2022-05-11T07:56:19Z

As far as the build it was shipped with, it seemed OK as far as the switches, but I didn't really try anything with it as I expected it to be out of date. Certainly need to liven someone up if they're not at least using the current state of this PR as the shipping build 😅

XING-IF · 2022-05-11T08:03:13Z

As far as the build it was shipped with, it seemed OK as far as the switches, but I didn't really try anything with it as I expected it to be out of date. Certainly need to liven someone ul if they're not at least using the current state of this PR as the shipping build 😅

I'm already releasing my anger and making sure this is a learned lesson. Mistakes can happen but should actually be found where they are made!

deadbytefpv · 2022-05-11T14:10:09Z

I had a little bit more play...
Added a second model from scratch.
Reconfigured the switches and also setup my mixes with those switches..
Also did the mixes on the first model (that came with the radio).
Let it sit a bit.. some 3 minutes or so.
Turned it off and didn't touched the radio for a while (turned off).

Just turned it On a moment ago and the switches are there. Didn't reset to None. On both models.
I've since deleted the second model. Switched to the first original model. I've turned the radio off, and powered it back on, and the switches seems to be intact.
I'll have some more play later and see if switch config sticks.
Will report here if there's any change.
Thanks!

EDIT: The issue has come back. Not sure what triggered it. But cannot "fix" it again with the steps outlined above.

… IF_commando8

into IF_commando8" This reverts commit 4af55a5, reversing changes made to 5a6633c.

into IF_commando8" This reverts commit 5a6633c, reversing changes made to 418aae6.

raphaelcoeffic · 2022-06-19T14:38:58Z

Obsoleted by #1982

XING-IF added 2 commits April 26, 2022 15:04

Add iFlight Commando8

b196328

Add iFlight Commando8 ELRS radio

Update CMakeLists.txt

27ef28d

fixed error

XING-IF marked this pull request as ready for review April 26, 2022 08:16

pfeerick reviewed Apr 26, 2022

View reviewed changes

companion/src/simulation/simulatorwidget.cpp Outdated Show resolved Hide resolved

Update simulatorwidget.cpp

aac26a5

fixed code

pfeerick reviewed Apr 26, 2022

View reviewed changes

radio/src/targets/common/arm/stm32/audio_dac_driver.cpp Outdated Show resolved Hide resolved

raphaelcoeffic requested changes Apr 27, 2022

View reviewed changes

XING-IF added 2 commits April 27, 2022 20:19

Merge branch 'EdgeTX:main' into IF_commando8

a95d00c

fix code after dev review

990ac33

several code fixes after suggestions in PR

XING-IF requested review from raphaelcoeffic and pfeerick April 28, 2022 04:32

pfeerick added 2 commits April 28, 2022 15:20

fix(actions): only build, no need for test

07c4f86

Since Commando8 is very similar to t8 architecture

fix(cleanup): Not needed as no pre-existing bin conv

85a4eb4

pfeerick reviewed Apr 28, 2022

View reviewed changes

radio/src/targets/common/arm/stm32/bootloader/boot.cpp Show resolved Hide resolved

Merge branch 'EdgeTX:main' into IF_commando8

9a533cd

raphaelcoeffic reviewed Apr 28, 2022

View reviewed changes

radio/src/gui/gui_common.cpp Outdated Show resolved Hide resolved

raphaelcoeffic reviewed Apr 28, 2022

View reviewed changes

radio/src/gui/gui_common.cpp Show resolved Hide resolved

pfeerick and others added 3 commits April 29, 2022 10:54

fix: Implement blExit() for horus and nv14

2d19b13

Update gui_common.cpp

8ff22d5

requested fix

Update build-companion-nightly.sh

418aae6

cleanup code

XING-IF requested review from raphaelcoeffic and pfeerick April 29, 2022 02:32

XING-IF added 4 commits April 29, 2022 10:47

Add iFlight Commando8

afedd0f

Add iFlight Commando8 ELRS radio

Update CMakeLists.txt

bdc1a9d

fixed error

Update simulatorwidget.cpp

36499f6

fixed code

fix code after dev review

da7e9a3

several code fixes after suggestions in PR

raphaelcoeffic force-pushed the IF_commando8 branch from 3bd0aa8 to 5f32399 Compare April 29, 2022 08:53

raphaelcoeffic added 4 commits April 29, 2022 11:04

fix: avoid repeating the same mute/unmute code

17439f0

indentation

860d1e4

BIND_KEY is OFF by default

a9302c8

IFLIGHT_RELEASE is already handled on main CMakeLists.txt

913218f

...and should only be set for releases compiled by the manufacturer.

Remove extra space in vers_stamp

b7dfa4c

raphaelcoeffic approved these changes Apr 29, 2022

View reviewed changes

pfeerick requested a review from elecpower April 29, 2022 09:39

Merge branch 'EdgeTX:main' into IF_commando8

28febba

XING-IF added 4 commits May 12, 2022 10:26

Merge branch 'IF_commando8' of https://github.com/XING-IF/edgetx into…

5a6633c

… IF_commando8

Merge branch 'IF_commando8' of https://github.com/XING-IF/edgetx into…

4af55a5

… IF_commando8

Revert "Merge branch 'IF_commando8' of https://github.com/XING-IF/edgetx

1fad8c3

into IF_commando8" This reverts commit 4af55a5, reversing changes made to 5a6633c.

Revert "Merge branch 'IF_commando8' of https://github.com/XING-IF/edgetx

725d08e

into IF_commando8" This reverts commit 5a6633c, reversing changes made to 418aae6.

XING-IF mentioned this pull request May 21, 2022

Add iFlight Commando8 ELRS PR fixed version2 #1982

Merged

raphaelcoeffic closed this Jun 19, 2022

pfeerick mentioned this pull request Aug 29, 2022

cpn: iFlight Commando8 support #2244

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add iFlight Commando8 #1902

Add iFlight Commando8 #1902

XING-IF commented Apr 26, 2022 •

edited

Loading

pfeerick left a comment •

edited

Loading

XING-IF commented Apr 26, 2022

XING-IF commented Apr 28, 2022

pfeerick commented Apr 29, 2022

XING-IF commented Apr 29, 2022 •

edited

Loading

raphaelcoeffic commented Apr 29, 2022

pfeerick commented Apr 29, 2022

pfeerick commented Apr 29, 2022

elecpower commented Apr 29, 2022

raphaelcoeffic commented Apr 29, 2022

XING-IF commented Apr 29, 2022

deadbytefpv commented May 11, 2022

pfeerick commented May 11, 2022

deadbytefpv commented May 11, 2022 •

edited

Loading

XING-IF commented May 11, 2022

pfeerick commented May 11, 2022 •

edited

Loading

XING-IF commented May 11, 2022

deadbytefpv commented May 11, 2022 •

edited

Loading

raphaelcoeffic commented Jun 19, 2022

Add iFlight Commando8 #1902

Add iFlight Commando8 #1902

Conversation

XING-IF commented Apr 26, 2022 • edited Loading

pfeerick left a comment • edited Loading

Choose a reason for hiding this comment

XING-IF commented Apr 26, 2022

XING-IF commented Apr 28, 2022

pfeerick commented Apr 29, 2022

XING-IF commented Apr 29, 2022 • edited Loading

raphaelcoeffic commented Apr 29, 2022

pfeerick commented Apr 29, 2022

pfeerick commented Apr 29, 2022

elecpower commented Apr 29, 2022

raphaelcoeffic commented Apr 29, 2022

XING-IF commented Apr 29, 2022

deadbytefpv commented May 11, 2022

pfeerick commented May 11, 2022

deadbytefpv commented May 11, 2022 • edited Loading

XING-IF commented May 11, 2022

pfeerick commented May 11, 2022 • edited Loading

XING-IF commented May 11, 2022

deadbytefpv commented May 11, 2022 • edited Loading

raphaelcoeffic commented Jun 19, 2022

XING-IF commented Apr 26, 2022 •

edited

Loading

pfeerick left a comment •

edited

Loading

XING-IF commented Apr 29, 2022 •

edited

Loading

deadbytefpv commented May 11, 2022 •

edited

Loading

pfeerick commented May 11, 2022 •

edited

Loading

deadbytefpv commented May 11, 2022 •

edited

Loading