Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cdt-gdb-vscode #285

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Conversation

marcdumais-work
Copy link
Contributor

License: EPL-2.0

Signed-off-by: Marc Dumais marc.dumais@ericsson.com

License: EPL-2.0

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
@marcdumais-work
Copy link
Contributor Author

For this extension, running yarn returns an error but the extension looks to work anyway, if one proceeds to package it, e.g. vsce package. This could be a problem here i think - the bot will likely stop when yarn returns status code 1.

Copy link
Collaborator

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @marcdumais-work!

For this extension, running yarn returns an error but the extension looks to work anyway, if one proceeds to package it, e.g. vsce package. This could be a problem here i think - the bot will likely stop when yarn returns status code 1.

Aha, thanks for the heads up. I think it's fine to try by merging this now and checking back after the CI had a go.

extensions.json Outdated Show resolved Hide resolved
@jankeromnes jankeromnes merged commit 618b2ff into EclipseFdn:master Feb 9, 2021
@marcdumais-work marcdumais-work deleted the cdt-gdb-vscode branch February 9, 2021 15:50
@jankeromnes
Copy link
Collaborator

@marcdumais-work Oops, auto-publishing failed with:

[FAIL] Could not process extension: {
  "id": "eclipse-cdt.cdt-gdb-vscode",
  "repository": "https://github.com/eclipse-cdt/cdt-gdb-vscode"
}
Error: Extension eclipse-cdt.cdt-gdb-vscode version 0.0.91 is already published, but is currently inactive and therefore not visible.

@spoenemann is this related to the publisher not having signed the Eclipse thing? What can be done in this case?

@spoenemann
Copy link
Collaborator

I deleted the previously published extension.

@jankeromnes
Copy link
Collaborator

Thanks! Auto-publishing now works again 🎉 https://open-vsx.org/extension/eclipse-cdt/cdt-gdb-vscode

tennox pushed a commit to tennox/publish-extensions that referenced this pull request Jan 21, 2022
Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants