Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add latest version of BazelBuild.vscode-bazel #282

Merged
merged 2 commits into from
Feb 8, 2021

Conversation

marcdumais-work
Copy link
Contributor

@marcdumais-work marcdumais-work commented Feb 4, 2021

Copy link
Collaborator

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, many thanks for adding this extension @marcdumais-work! 🙏

Also, FYI the new recommended way to add extensions here is to simply run:

node add-extension REPO_URL --checkout

This will almost always do exactly the right thing (e.g. here, there is an official .vsix release availble, so the script will prefer re-publishing that directly).

extensions.json Outdated
Comment on lines 161 to 166
{
"id": "BazelBuild.vscode-bazel",
"repository": "https://github.com/bazelbuild/vscode-bazel",
"version": "0.4.0",
"checkout": "0.4.0"
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run node add-extension https://github.com/bazelbuild/vscode-bazel --checkout, I get this instead:

Suggested change
{
"id": "BazelBuild.vscode-bazel",
"repository": "https://github.com/bazelbuild/vscode-bazel",
"version": "0.4.0",
"checkout": "0.4.0"
},
{
"id": "BazelBuild.vscode-bazel",
"download": "https://github.com/bazelbuild/vscode-bazel/releases/download/0.4.0/vscode-bazel-0.4.0.vsix",
"version": "0.4.0"
},

@jankeromnes jankeromnes merged commit 082bde8 into EclipseFdn:master Feb 8, 2021
@marcdumais-work marcdumais-work deleted the vscode-bazel branch February 8, 2021 15:46
@marcdumais-work
Copy link
Contributor Author

Thanks @jankeromnes!

@jankeromnes
Copy link
Collaborator

@marcdumais-work Oops, auto-publishing failed with the same error as in #285 (comment):

Downloading https://github.com/bazelbuild/vscode-bazel/releases/download/0.4.0/vscode-bazel-0.4.0.vsix
[FAIL] Could not process extension: {
  "id": "BazelBuild.vscode-bazel",
  "download": "https://github.com/bazelbuild/vscode-bazel/releases/download/0.4.0/vscode-bazel-0.4.0.vsix",
  "version": "0.4.0"
}
Error: Extension BazelBuild.vscode-bazel version 0.4.0 is already published, but is currently inactive and therefore not visible.

@marcdumais-work
Copy link
Contributor Author

@spoenemann could you similarly delete the "ghost" extension preventing this one here being re-published?

@spoenemann
Copy link
Collaborator

Done

tennox pushed a commit to tennox/publish-extensions that referenced this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants