Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hashicorp.vscode-terraform #105

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Add hashicorp.vscode-terraform #105

merged 2 commits into from
Aug 7, 2020

Conversation

Mayeu
Copy link
Contributor

@Mayeu Mayeu commented Aug 5, 2020

No description provided.

@jankeromnes
Copy link
Collaborator

Hi @Mayeu, many thanks for the contribution!

It would be awesome to have hashicorp.vscode-terraform on https://open-vsx.org, and your addition looks good. 👍

Still, it would be even better if this extension gets published by its original authors, because our auto-publish script here is a bit basic and publishes extensions as a generic bot user on OpenVSX.

I actually implemented a publishing script for this extension in hashicorp/vscode-terraform#388 and am now waiting for feedback. If they're not interested, I'd be okay to publish the extension automatically from here by merging your PR (so, thanks again for making it!).

@jankeromnes
Copy link
Collaborator

Note: This PR is a possible alternative to hashicorp/vscode-terraform#388 for fixing hashicorp/vscode-terraform#379

@jankeromnes
Copy link
Collaborator

jankeromnes commented Aug 7, 2020

@paultyng @appilon @radeksimko To get the Terraform extension published to OpenVSX sooner, we'll merge @Mayeu's Pull Request here, which will start publishing hashicorp.vscode-terraform to https://open-vsx.org under a generic OpenVSX bot user.

When you have time, please take a look at hashicorp/vscode-terraform#379 and let us know when you are ready to take over the OpenVSX publishing -- we'll be more than happy to help you set it up and to hand over the publishing.

@jankeromnes jankeromnes merged commit c0883c6 into EclipseFdn:master Aug 7, 2020
@jankeromnes
Copy link
Collaborator

jankeromnes commented Aug 7, 2020

Unfortunately, automated publishing failed with:

Executing prepublish script 'npm run vscode:prepublish'...

> terraform@2.1.1 vscode:prepublish /tmp/repository
> npm run test && npm run compile


> terraform@2.1.1 test /tmp/repository
> npm run test-compile && node ./out/test/runTest.js


> terraform@2.1.1 test-compile /tmp/repository
> tsc -p ./

Downloading VS Code 1.47.3 from https://update.code.visualstudio.com/1.47.3/linux-x64/stable
Downloaded VS Code 1.47.3 into .vscode-test/vscode-1.47.3
Exit code:   null
Done

Failed
Failed to run tests
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! terraform@2.1.1 test: `npm run test-compile && node ./out/test/runTest.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the terraform@2.1.1 test script.

EDIT: #113

tennox pushed a commit to tennox/publish-extensions that referenced this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants