Revert pio1 cmake path to point into pio2 #1480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add back in the pointing of pio1 into pio2/cmake, for now.
The CMakelists.txt file for pio1/pio used to point into pio2/cmake for functions like FindNetCDF.cmake.
commit "Dont point to pio2 cmake modules by default"
PR#1352
This was changed in pio1/pio to point to "${CMAKE_CURRENT_SOURCE_DIR}/cmake" which doesn't exist.
Without a FindNetCDF, the ACMCE build of the HOMME test to fail.
Changing this back to HOMME build works again until a better fix is found or we switch to pio2.
|
Andy, |
jedwards4b
reviewed
May 4, 2017
|
A fix that sets USER_CMAKE_MODULE_PATH sounds preferable. Hopefully @jayeshkrishna can figure out where to do this. This is the ACME test to verify: HOMME_P24.f19_g16_rx1.A |
|
The right fix for HOMME tests to work is in E3SM-Project/E3SM#1480 . Specifically commit - E3SM-Project/E3SM@443aa5e |
jayeshkrishna
requested changes
May 4, 2017
|
OK, that sounds good. We're having trouble getting the sequence correct and finding the same bug twice. One thing that still looks wrong to me is pointing to the pio1/pio/cmake dir that doesn't exist, but that doesn't effect me. |
jgfouca
pushed a commit
that referenced
this pull request
Jun 2, 2017
Get HOMME tests to build on Mira. The following merge, * Brings in the latest version of pio1 (includes changes to pio1 cmake configure files required for this issue) * Updates HOMME cmake configure files to include pio2 cmake modules See Issue #1411 [BFB] * jayeshkrishna/mira_homme_test_update_pio1: Add path to pio2 cmake modules for HOMME tests Updating PIO1 to latest master
jgfouca
pushed a commit
that referenced
this pull request
Feb 23, 2018
Get HOMME tests to build on Mira. The following merge, * Brings in the latest version of pio1 (includes changes to pio1 cmake configure files required for this issue) * Updates HOMME cmake configure files to include pio2 cmake modules See Issue #1411 [BFB] * jayeshkrishna/mira_homme_test_update_pio1: Add path to pio2 cmake modules for HOMME tests Updating PIO1 to latest master
jgfouca
pushed a commit
that referenced
this pull request
Mar 13, 2018
Get HOMME tests to build on Mira. The following merge, * Brings in the latest version of pio1 (includes changes to pio1 cmake configure files required for this issue) * Updates HOMME cmake configure files to include pio2 cmake modules See Issue #1411 [BFB] * jayeshkrishna/mira_homme_test_update_pio1: Add path to pio2 cmake modules for HOMME tests Updating PIO1 to latest master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add back in the pointing of pio1 into pio2/cmake, for now.
The CMakelists.txt file for pio1/pio used to point into pio2/cmake for functions like FindNetCDF.cmake.
commit "Dont point to pio2 cmake modules by default"
PR#1352
This was changed in pio1/pio to point to "${CMAKE_CURRENT_SOURCE_DIR}/cmake" which doesn't exist.
Without a FindNetCDF, the ACMCE build of the HOMME test to fail.
Changing this back to HOMME build works again until a better fix is found or we switch to pio2.
Test suite: Discovered in ACME -- just typed it in here without running tests.
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes: ACME integration of CIME master as of May 2