-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get HOMME tests to work on Mira #1480
Merged
jayeshkrishna
merged 2 commits into
master
from
jayeshkrishna/mira_homme_test_update_pio1
May 12, 2017
Merged
Get HOMME tests to work on Mira #1480
jayeshkrishna
merged 2 commits into
master
from
jayeshkrishna/mira_homme_test_update_pio1
May 12, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating PIO1 to latest master ( 80c30ec6a20bf5d83eeecd5d0c5dba5d5f57cb26 ). Note: This commit includes changes to pio1 cmake configure files Also see Issue #1411 [BFB]
The latest version of PIO1 requires access to both PIO2 cmake modules (to get the latest version of cmake modules) and the older version of cmake modules (for some tests that are no longer available in the latest version of cmake modules). So adding paths to the latest cmake modules that are available with pio2. Fixes #1411 [BFB]
This was referenced May 2, 2017
This fixes the build issue with
|
amametjanov
approved these changes
May 4, 2017
jayeshkrishna
added a commit
that referenced
this pull request
May 12, 2017
Get HOMME tests to build on Mira. The following merge, * Brings in the latest version of pio1 (includes changes to pio1 cmake configure files required for this issue) * Updates HOMME cmake configure files to include pio2 cmake modules See Issue #1411 [BFB] * jayeshkrishna/mira_homme_test_update_pio1: Add path to pio2 cmake modules for HOMME tests Updating PIO1 to latest master
jgfouca
pushed a commit
that referenced
this pull request
Jun 2, 2017
Get HOMME tests to build on Mira. The following merge, * Brings in the latest version of pio1 (includes changes to pio1 cmake configure files required for this issue) * Updates HOMME cmake configure files to include pio2 cmake modules See Issue #1411 [BFB] * jayeshkrishna/mira_homme_test_update_pio1: Add path to pio2 cmake modules for HOMME tests Updating PIO1 to latest master
jgfouca
pushed a commit
that referenced
this pull request
Feb 27, 2018
Get HOMME tests to build on Mira. The following merge, * Brings in the latest version of pio1 (includes changes to pio1 cmake configure files required for this issue) * Updates HOMME cmake configure files to include pio2 cmake modules See Issue #1411 [BFB] * jayeshkrishna/mira_homme_test_update_pio1: Add path to pio2 cmake modules for HOMME tests Updating PIO1 to latest master
jgfouca
pushed a commit
that referenced
this pull request
Mar 14, 2018
Get HOMME tests to build on Mira. The following merge, * Brings in the latest version of pio1 (includes changes to pio1 cmake configure files required for this issue) * Updates HOMME cmake configure files to include pio2 cmake modules See Issue #1411 [BFB] * jayeshkrishna/mira_homme_test_update_pio1: Add path to pio2 cmake modules for HOMME tests Updating PIO1 to latest master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get HOMME tests to build on Mira. The following merge,
cmake configure files required for this issue)
modules
See Issue #1411
[BFB]