-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove hardcoded compclasses #1210
Conversation
Did you test all of these modified scripts? I don't think scripts_regression_tests.py tests them all (e.g., ncr). |
Testing of ncr indicates that it didn't work before this PR. Would you like me to jump down this rabbit hole? |
Well, it sort of says that our testing program is not very robust. At the very least, you should document the status in this PR. |
Rabbit hole jumping ... tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this merged before the requests were fulfilled? This PR still is not correctly documented and a new issue should be opened for the failing test.
I merged it so I could run the cesm2_0_alpha06g overnight. |
Why was this PR required? We always seem to be rushing around and now we have code in master which either has not been tested or at the least has tests which are undocumented. |
I messed up. I thought Jim told be to go ahead and make a tag with this PR. It was really without |
I reverted this PR, but I'm can't reopen it. I think Jim needs to make a new PR. Sorry about |
Also you'll need to "revert the revert" when you finally put this branch on master. |
Which is better, to "revert the revert", or make a new PR? |
If the PR is for the same branch, you'll still have to revert the revert. See https://git-scm.com/blog/2010/03/02/undoing-merges.html |
Removes some lingering hardcoded lists of COMP_CLASSES and uses get_values instead
Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes #1170
Fixes #1171
User interface changes?:
Code review: