Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_timing.py specifies component classes by hand #1170

Closed
gold2718 opened this issue Feb 19, 2017 · 0 comments
Closed

get_timing.py specifies component classes by hand #1170

gold2718 opened this issue Feb 19, 2017 · 0 comments
Assignees
@gold2718 @jedwards4b @mvertens @bertinia @fischer-ncar
Labels
ty: question

Comments

@gold2718
Copy link

Are lines like this:
for k in ['CPL', 'GLC', 'WAV', 'LND', 'ROF', 'ICE', 'ATM', 'OCN']:
appropriate in get_timing.py? They prevent get_timing from automatically picking up new component types (e.g., ESP).
@rljacob rljacob added the ready label Mar 3, 2017
@jedwards4b jedwards4b mentioned this issue Mar 6, 2017
Merged
@ghost ghost added in progress and removed ready labels Mar 6, 2017
@ghost ghost assigned fischer-ncar Mar 7, 2017
@ghost ghost removed the in progress label Mar 7, 2017
@ghost ghost assigned gold2718 Mar 7, 2017
@ghost ghost added the in progress label Mar 7, 2017
@fischer-ncar fischer-ncar reopened this Mar 7, 2017
@jedwards4b jedwards4b mentioned this issue Mar 9, 2017
Merged
jedwards4b added a commit that referenced this issue Mar 10, 2017
@jedwards4b
Merge pull request #1226 from jedwards4b/compclasses_cleanup
ab579b3 
Compclasses cleanup
Get rid of hard coded comp_class settings and use get_values instead.
Punting on NCR test - it's broken, was broken before this PR will open a ticket.

Test suite: scripts_regression_tests.py, hand tests of PET and PEM tests. PEM.f19_g16.F1850.yellowstone_intel
PET.f19_g16.F1850.yellowstone_intel
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #1170

User interface changes?:

Code review: gold2718
@ghost ghost removed the in progress label Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gold2718 gold2718

@jedwards4b jedwards4b

@mvertens mvertens

@bertinia bertinia

@fischer-ncar fischer-ncar

Labels
ty: question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@rljacob @gold2718 @jedwards4b @mvertens @bertinia @fischer-ncar