Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update standard name rules with rules for units #21

Merged
merged 4 commits into from
Aug 24, 2021

Conversation

climbfuji
Copy link
Collaborator

Add a section about rules for variables to the standard name rules. In particular, provide guidance for dimensionless variables.

Disclaimer. I created this PR on GitHub without actually rendering the rst file.

See #19 and NCAR/ccpp-framework#397 for discussions related to this PR.

@climbfuji
Copy link
Collaborator Author

@ligiabernardet @dudhia I just invited you as collaborators for CCPPStandardNames so that I can add you as reviewers. In the meantime, please see this PR for a proposed extension of the standard name rules regarding units.

Copy link
Collaborator

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very clear and a welcome addition to the StandardNames

@climbfuji climbfuji requested a review from dudhia August 23, 2021 15:58
| flag | logicals/booleans that can be either true or false |
| index | integers that can be an index in an array |
| kg kg-1 | mass mixing ratios |
| m m-3 | volumetric mixing ratios (e.g. for soil moisture) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be m3 m-3 - seems OK otherwise

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, stupid mistake. Should be fixed now. Please approve if satisfied. Thanks!

@climbfuji climbfuji force-pushed the climbfuji-update-rules-units branch from ccd8879 to 175f7a3 Compare August 23, 2021 16:12
Copy link
Collaborator

@dudhia dudhia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine now

@dudhia
Copy link
Collaborator

dudhia commented Aug 23, 2021 via email

@climbfuji
Copy link
Collaborator Author

With this new index definition, will the previous real 'index' types be corrected in the standard names file? Will there be a new category unit that should be added here?

The way I understood our previous conversations was that we accepted there are issues with these reals, and we (... well, me) are going to fix this as soon as possible. In the meantime, we chose to "ignore".

@dudhia
Copy link
Collaborator

dudhia commented Aug 23, 2021 via email

Copy link
Collaborator

@ligiabernardet ligiabernardet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this effort in clarifying the units, especially the dimensionless ones.

+------------------------+-------------------------------------------------------------------------------------+
| **Unit** | **Use case** |
+========================+=====================================================================================+
| count | integers that describe the dimension/length of an array |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table is not rendered correctly. Please use other tables as a template, and note that there must be a dashed line between each lines of the table.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, should be ok now. I rendered it on my mac using rst2html.py StandardNamesRules.rst > StandardNamesRules.html and the results looked ok.

climbfuji and others added 2 commits August 23, 2021 20:00
Fix volumetric mixing ratios

Co-authored-by: ligiabernardet <ligia.bernardet@noaa.gov>
@dudhia
Copy link
Collaborator

dudhia commented Aug 24, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants