New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccpp_error_flag does not conform to stated CCPPStandardName (ESCOMP) rules #399

Open

grantfirl opened this issue Aug 25, 2021 · 1 comment

Labels

Collaborator

grantfirl commented Aug 25, 2021

Summary of Issue: According to ESCOMP/ESMStandardNames#21, the standard name with variable ccpp_error_flag does not conform to the rules: "flag" should only be used with logical data types and since it is an integer (but not an "index" or "count"), the units should be 1. These changes are reflected in ESCOMP/ESMStandardNames#13, but were not propagated to ccpp-framework, ccpp-physics, fv3atm, and ccpp-scm. This should be done together when a good opportunity presents (perhaps when ccpp-framework has more sophisticated error handling or some other time).

Expected behavior and actual behavior: Only an inconsistency with stated CCPP standard name rules

Steps to reproduce the problem (should include model description file(s) or link to publi c repository): N/A

What is the changeset ID of the code, and the machine you are using: N/A

have you modified the code? If so, it must be committed and available for testing: N/A

Screen output or log file showing the error message and context: N/A

grantfirl added the ccpp_prebuild label

Collaborator Author

grantfirl commented Aug 25, 2021

Related to #350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment