Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize the physics grid directly from dyn_grid_init #89

Merged
merged 8 commits into from
Jan 21, 2021

Conversation

nusbaume
Copy link
Collaborator

@nusbaume nusbaume commented Jan 8, 2021

Re-configured the physics-dynamics grid initialization for the Null dycore, so that the initialization is done by passing variables directly from dyn_grid_init (now renamed model_grid_init) to phys_grid_init, instead of using specialized subroutines and pointers.

Fixes #88
Fixes #90

Tests run:

Successful simulation of null dycore with Kessler physics suite on Cheyenne with Intel and on Izumi with NAG and PGI. The Intel and NAG test were also run with debug flags enabled. Finally, one simulation was done with debug print statements to ensure that the physics_column_type assignment operator was working correctly, and that the phys_grid_init routine was receiving the correct inputs.

…ing interface for Null dycore initialization.
@nusbaume nusbaume added enhancement New feature or request BFB bit for bit tag labels Jan 8, 2021
@nusbaume nusbaume requested a review from gold2718 January 8, 2021 19:06
@nusbaume nusbaume self-assigned this Jan 8, 2021
@nusbaume
Copy link
Collaborator Author

nusbaume commented Jan 8, 2021

@gold2718 Please let me know if these changes are what you generally had in mind. If so then I'll go ahead and add Cheryl as well. Thanks!

Copy link
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, just a couple of small fixes.

@nusbaume
Copy link
Collaborator Author

Adding @cacraigucar to review the code as well, if she wants.

Also, along with the requested changes I added some allocate checks as discussed in issue #91 . Let me know if this is not what you all had in mind.

Copy link
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more changes.

@nusbaume
Copy link
Collaborator Author

I also made modifications for issue #90 . Given that it sounds like only to_lower and to_upper were being replaced, at least for the foreseeable future, I went ahead and marked the issue as being closed by this PR.

Of course if you would like to keep the issue open, even after these modifications, just let me know. Thanks!

@nusbaume nusbaume requested a review from gold2718 January 15, 2021 22:12
Copy link
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested comment change and issue in phys_grid_init.

@nusbaume nusbaume requested a review from gold2718 January 19, 2021 18:11
Copy link
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thanks!

@nusbaume nusbaume merged commit 09a41a9 into ESCOMP:master Jan 21, 2021
@nusbaume nusbaume deleted the dyn_phys_init branch January 21, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB bit for bit tag enhancement New feature or request
Projects
None yet
3 participants