-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize the physics grid directly from dyn_grid_init #89
Conversation
…ing interface for Null dycore initialization.
@gold2718 Please let me know if these changes are what you generally had in mind. If so then I'll go ahead and add Cheryl as well. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, just a couple of small fixes.
Adding @cacraigucar to review the code as well, if she wants. Also, along with the requested changes I added some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more changes.
I also made modifications for issue #90 . Given that it sounds like only Of course if you would like to keep the issue open, even after these modifications, just let me know. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested comment change and issue in phys_grid_init
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now, thanks!
Re-configured the physics-dynamics grid initialization for the Null dycore, so that the initialization is done by passing variables directly from
dyn_grid_init
(now renamedmodel_grid_init
) tophys_grid_init
, instead of using specialized subroutines and pointers.Fixes #88
Fixes #90
Tests run:
Successful simulation of null dycore with Kessler physics suite on Cheyenne with Intel and on Izumi with NAG and PGI. The Intel and NAG test were also run with debug flags enabled. Finally, one simulation was done with debug print statements to ensure that the
physics_column_type
assignment operator was working correctly, and that thephys_grid_init
routine was receiving the correct inputs.