Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

受注管理画面の Warning 修正 #1130

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Jan 9, 2025

#1129 を先にマージしてください

@bbkids
Copy link
Contributor

bbkids commented Jan 9, 2025

data/class/pages/admin/order/LC_Page_Admin_Order_ProductSelect.php
$page_max = SC_Utils_Ex::sfGetSearchPageMax($_POST['search_page_max'] ?? 1);

これやると検索結果が1ページ1個しか表示されなくなります。

@nanasess
Copy link
Contributor Author

@bbkids すみません、ありがとうございます🙇‍♂️
修正しました。

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.93%. Comparing base (1ffd347) to head (d315f71).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1130   +/-   ##
=======================================
  Coverage   49.93%   49.93%           
=======================================
  Files          82       82           
  Lines       10482    10482           
=======================================
  Hits         5234     5234           
  Misses       5248     5248           
Flag Coverage Δ
tests 49.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess nanasess enabled auto-merge January 16, 2025 06:22
@nanasess nanasess merged commit 35e42bf into EC-CUBE:master Jan 16, 2025
108 checks passed
@nanasess nanasess deleted the fix-warning-order-edit branch January 16, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants