Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

受注編集画面で数値項目に空文字を入力された場合にシステムエラーになるのを修正 #1129

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Jan 9, 2025

refs #829
とり急ぎ応急処置。数量及び税率が空文字の場合は0にキャストする。
根治対応は #836 で行う

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.94%. Comparing base (6760492) to head (5d96e1d).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1129   +/-   ##
=======================================
  Coverage   49.94%   49.94%           
=======================================
  Files          82       82           
  Lines       10480    10480           
=======================================
  Hits         5234     5234           
  Misses       5246     5246           
Flag Coverage Δ
tests 49.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@seasoftjapan seasoftjapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

数量を空文字としても、登録できた。
再表示時は 0 となっていた。

@nanasess nanasess merged commit 26f7a7e into EC-CUBE:master Jan 13, 2025
108 checks passed
@nanasess nanasess deleted the fix-order-edit branch January 13, 2025 13:06
@nanasess nanasess added this to the 2.25 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants