Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #1107

Merged
merged 3 commits into from
Dec 26, 2024
Merged

Fix warnings #1107

merged 3 commits into from
Dec 26, 2024

Conversation

nanasess
Copy link
Contributor

主に #1095 のテストで出力される warning の解消

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 50.60%. Comparing base (cd15650) to head (39133d1).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
data/class/helper/SC_Helper_Delivery.php 0.00% 3 Missing ⚠️
data/class/helper/SC_Helper_FileManager.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1107      +/-   ##
==========================================
- Coverage   50.61%   50.60%   -0.01%     
==========================================
  Files          80       80              
  Lines       10256    10258       +2     
==========================================
  Hits         5191     5191              
- Misses       5065     5067       +2     
Flag Coverage Δ
tests 50.60% <78.94%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess nanasess added this to the 2.18(仮) milestone Dec 25, 2024
@nanasess nanasess enabled auto-merge December 26, 2024 01:36
@nanasess nanasess merged commit 03fa814 into EC-CUBE:master Dec 26, 2024
109 checks passed
@nanasess nanasess deleted the fix-warnings branch December 26, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants