Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endpoints.csv に記載されたURLがすべて表示されることを確認するテストを追加 #1095

Merged
merged 4 commits into from
Dec 24, 2024

Conversation

nanasess
Copy link
Contributor

endpoints.csv に記載されたURLにアクセスし、get で表示されることを確認するテストを追加。
除外したいURLは exclude_endpoints.csv に記載する。
今のところ、 /admin, /mypage, /order, /guide, /abouts に対応。

また、ログインする際に使用していた fixture の型を、 fixture ごとに定義するよう修正。
これにより、 管理画面にログインしつつ、 マイページのテストをすることが可能になる

@nanasess nanasess enabled auto-merge December 20, 2024 06:29
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.94%. Comparing base (8ab728f) to head (42fcefd).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1095   +/-   ##
=======================================
  Coverage   50.94%   50.94%           
=======================================
  Files          80       80           
  Lines       10256    10256           
=======================================
  Hits         5225     5225           
  Misses       5031     5031           
Flag Coverage Δ
tests 50.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess nanasess added this to the 2.18(仮) milestone Dec 20, 2024
@nanasess nanasess merged commit 980ce37 into EC-CUBE:master Dec 24, 2024
109 checks passed
@nanasess nanasess deleted the add-endpoint-tests branch December 24, 2024 05:13
@nanasess nanasess mentioned this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants