Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php-cs-fixer を適用 #1086

Merged
merged 11 commits into from
Dec 20, 2024
Merged

php-cs-fixer を適用 #1086

merged 11 commits into from
Dec 20, 2024

Conversation

nanasess
Copy link
Contributor

#1068 で追加されたルールに伴い php-cs-fixer を適用

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 11.84834% with 186 lines in your changes missing coverage. Please review.

Project coverage is 51.70%. Comparing base (0ac0b1d) to head (1daa15b).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
data/class/helper/SC_Helper_CSV.php 0.00% 149 Missing ⚠️
data/class/api/SC_Api_Operation.php 0.00% 12 Missing ⚠️
data/class/SC_Fpdf.php 0.00% 4 Missing ⚠️
data/class/SC_SendMail.php 0.00% 4 Missing ⚠️
data/class/api/operations/AddrFromZip.php 0.00% 4 Missing ⚠️
data/class/util/SC_Utils.php 42.85% 4 Missing ⚠️
data/class/SC_Customer.php 0.00% 2 Missing ⚠️
data/class/SC_Initial.php 0.00% 2 Missing ⚠️
data/class/api/operations/BrowseNodeLookup.php 0.00% 1 Missing ⚠️
data/class/api/operations/ItemSearch.php 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1086      +/-   ##
==========================================
- Coverage   51.71%   51.70%   -0.02%     
==========================================
  Files          80       80              
  Lines       10218    10222       +4     
==========================================
+ Hits         5284     5285       +1     
- Misses       4934     4937       +3     
Flag Coverage Δ
tests 51.70% <11.84%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess nanasess mentioned this pull request Dec 18, 2024
3 tasks
@nanasess nanasess enabled auto-merge December 18, 2024 13:18
@nanasess nanasess added this to the 2.18(仮) milestone Dec 20, 2024
@nobuhiko
Copy link
Contributor

Conflictがー

@nanasess
Copy link
Contributor Author

@nobuhiko コンフリクト解消しました🙇‍♂️

@nanasess nanasess merged commit 6235b10 into EC-CUBE:master Dec 20, 2024
105 of 107 checks passed
@nanasess nanasess deleted the apply-php-cs-fixer branch December 20, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants