Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions で php-cs-fixer を実行し、エラーがある場合は diff を表示する #1073

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Dec 8, 2024

refs #1025

  • GitHub Actions で php-cs-fixer fix --diff --dry-run --allow-risky=yes を実行する
  • エラーがある場合は diff を表示する
  • エラーの場合は後続のワークフローを実行しない

#1086 を先にマージしてください

@nanasess nanasess mentioned this pull request Dec 8, 2024
3 tasks
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.70%. Comparing base (6235b10) to head (5b6c587).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1073   +/-   ##
=======================================
  Coverage   51.70%   51.70%           
=======================================
  Files          80       80           
  Lines       10222    10222           
=======================================
  Hits         5285     5285           
  Misses       4937     4937           
Flag Coverage Δ
tests 51.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess
Copy link
Contributor Author

nanasess commented Dec 9, 2024

エラーの場合は以下のような diff を表示します
image

@nanasess nanasess enabled auto-merge December 9, 2024 08:46
@nanasess nanasess added this to the 2.18(仮) milestone Dec 16, 2024
@nanasess nanasess merged commit d38820d into EC-CUBE:master Dec 20, 2024
109 checks passed
@nanasess nanasess deleted the gh-actions-php-cs-fixer branch December 20, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants