Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OWASP ZAP] 会員管理 会員登録 #5330

Merged
merged 8 commits into from
May 19, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/penetration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ jobs:
- 'test/front_guest/contact.test.ts'
- 'test/admin/content_layout.test.ts'
- 'test/admin/content_layout_delete.test.ts'
- 'test/admin/customer_new.test.ts'
- 'test/admin/order_mail.test.ts'

steps:
Expand Down
89 changes: 89 additions & 0 deletions zap/selenium/ci/TypeScript/test/admin/customer_new.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
import { test, expect, chromium, Page } from '@playwright/test';
import PlaywrightConfig from '../../playwright.config';
import { intervalRepeater } from '../../utils/Progress';
import { ZapClient, Mode, ContextType, Risk, HttpMessage } from '../../utils/ZapClient';
import { ECCUBE_ADMIN_ROUTE } from '../../config/default.config';

const zapClient = new ZapClient();

const url = `${PlaywrightConfig.use.baseURL}/${ECCUBE_ADMIN_ROUTE}/customer/new`;

test.describe.serial('会員管理 会員登録のテストを行います', () => {
let page: Page;
test.beforeAll(async () => {
await zapClient.setMode(Mode.Protect);
await zapClient.newSession('/zap/wrk/sessions/admin_customer_new', true);
await zapClient.importContext(ContextType.Admin);

if (!await zapClient.isForcedUserModeEnabled()) {
await zapClient.setForcedUserModeEnabled();
expect(await zapClient.isForcedUserModeEnabled()).toBeTruthy();
}
const browser = await chromium.launch();
page = await browser.newPage();
await page.goto(url);
});

test('会員管理 会員登録のページを表示します', async () => {
await expect(page).toHaveTitle(/会員登録/);
});

test('タイトルを確認します', async () => {
await page.textContent('.c-pageTitle__subTitle')
.then(title => expect(title).toContain('会員管理'));
});

test.describe('テストを実行します[GET] @attack', () => {
let scanId: number;
test('アクティブスキャンを実行します', async () => {
scanId = await zapClient.activeScanAsUser(url, 2, 55, false, null, 'GET');
await intervalRepeater(async () => await zapClient.getActiveScanStatus(scanId), 5000, page);
});

test('結果を確認します', async () => {
await zapClient.getAlerts(url, 0, 1, Risk.High)
.then(alerts => expect(alerts).toEqual([]));
});
});

test('ユーザ情報を入力します', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

エスケープ文字 \\ で煩雑な記述になっているため、ID 指定の方がシンプルに記述できそうですが、いかがでしょう?

await page.fill('[placeholder="姓"]', '山田');
await page.fill('[placeholder="名"]', '太郎');
await page.fill('[placeholder="セイ"]', 'ヤマダ');
await page.fill('[placeholder="メイ"]', 'タロウ');
await page.fill('input[name="admin_customer\\[company_name\\]"]', 'イーシーキューブ');
await page.fill('[placeholder="例:5300001"]', '5300001');
await page.click('select[name="admin_customer\\[address\\]\\[pref\\]"]');
await page.selectOption('select[name="admin_customer\\[address\\]\\[pref\\]"]', '1');
await page.fill('[placeholder="市区町村名\\(例:大阪市北区\\)"]', '大阪市北区梅田');
await page.fill('[placeholder="番地・ビル名\\(例:西梅田1丁目6-8\\)"]', '2-4-9');
await page.fill('[placeholder="例:ec-cube\\@example\\.com"]', 'taro_yamada@test.local');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

メールアドレスが固定されているため、 常に このメールアドレスは利用できません というエラーになってしまうようです。
entityManager->flush() を抑制するパッチを当てる必要がありそうですが、いかがでしょうか。

await page.fill('[placeholder="例:11122223333"]', '0001112222');
await page.fill('input[name="admin_customer\\[password\\]\\[first\\]"]', 'password123');
await page.fill('input[name="admin_customer\\[password\\]\\[second\\]"]', 'password123');
await page.click('input[name="admin_customer\\[sex\\]"]');
await page.selectOption('select[name="admin_customer\\[job\\]"]', '3');
await page.fill('input[name="admin_customer\\[birth\\]"]', '1980-04-01');
await page.fill('input[name="admin_customer\\[point\\]"]', '10');
await page.fill('textarea[name="admin_customer\\[note\\]"]', '国語国語国語国語国語国語国語国語国語国語国語国語国語国語国語国語国語国語国語国語国語国語');
await page.click('button:has-text("登録")');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
await page.click('button:has-text("登録")');
await page.click('button >> text=登録');

で、いかがでしょうか?

});

let message: HttpMessage;
test('HttpMessage を取得します', async () => {
message = await zapClient.getLastMessage(url);
});

test.describe('テストを実行します[POST][入力→登録] @attack', () => {
let scanId: number;
test('アクティブスキャンを実行します', async () => {
scanId = await zapClient.activeScan(url, false, true, null, 'POST', message.requestBody);
await intervalRepeater(async () => await zapClient.getActiveScanStatus(scanId), 5000, page);
});

test('ユーザ登録の結果を確認します', async () => {
await zapClient.getAlerts(url, 0, 1, Risk.High)
.then(alerts => expect(alerts).toEqual([]));
});
});
});