[OWASP ZAP] 会員管理 会員登録 #5330
Merged
[OWASP ZAP] 会員管理 会員登録 #5330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 4.1 #5330 +/- ##
=========================================
Coverage 68.55% 68.56%
Complexity 6159 6159
=========================================
Files 463 463
Lines 25279 25279
=========================================
+ Hits 17331 17333 +2
+ Misses 7948 7946 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nanasess
requested changes
Mar 28, 2022
| await page.selectOption('select[name="admin_customer\\[address\\]\\[pref\\]"]', '1'); | ||
| await page.fill('[placeholder="市区町村名\\(例：大阪市北区\\)"]', '大阪市北区梅田'); | ||
| await page.fill('[placeholder="番地・ビル名\\(例：西梅田1丁目6-8\\)"]', '2-4-9'); | ||
| await page.fill('[placeholder="例：ec-cube\\@example\\.com"]', 'taro_yamada@test.local'); |
There was a problem hiding this comment.
メールアドレスが固定されているため、 常に このメールアドレスは利用できません というエラーになってしまうようです。
entityManager->flush() を抑制するパッチを当てる必要がありそうですが、いかがでしょうか。
| await page.fill('input[name="admin_customer\\[birth\\]"]', '1980-04-01'); | ||
| await page.fill('input[name="admin_customer\\[point\\]"]', '10'); | ||
| await page.fill('textarea[name="admin_customer\\[note\\]"]', '国語国語国語国語国語国語国語国語国語国語国語国語国語国語国語国語国語国語国語国語国語国語'); | ||
| await page.click('button:has-text("登録")'); |
There was a problem hiding this comment.
Suggested change
| await page.click('button:has-text("登録")'); | |
| await page.click('button >> text=登録'); |
で、いかがでしょうか？
| }); | ||
| }); | ||
|
|
||
| test('ユーザ情報を入力します', async () => { |
There was a problem hiding this comment.
エスケープ文字 \\ で煩雑な記述になっているため、ID 指定の方がシンプルに記述できそうですが、いかがでしょう？
|
@nanasess |
nanasess
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
Owasp ZAP 自動化: 管理画面 > 会員管理 会員登録 > 新規登録
方針(Policy)
実装に関する補足(Appendix)
テスト（Test)
手元の環境で動作確認を行っています。
相談（Discussion）
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目