Update descriptions of dcEdge and dvEdge
#6427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing descriptions were not clear to developers.
|
This PR was discussed and reviewed in E3SM-Ocean-Discussion#99 |
proteanplanet
approved these changes
May 17, 2024
matthewhoffman
approved these changes
May 17, 2024
|
@xylar -- I ran the scripts to make sure the Registry changes didn't impact the old files for any component. It didn't turn up anything due to this PR, but did find a couple of small issues in mpassi that had somehow snuck in. I can either add them to this PR or make a separate PR to clean them up |
|
@jonbob, sure, please include them here. |
jonbob
added a commit
that referenced
this pull request
May 21, 2024
#6427) Update descriptions of dcEdge and dvEdge This PR just updates the metadata that will be produced in files that contain the MPAS mesh. The description of these two variables has been updated to help developers (and users) better understand what they mean. [BFB]
|
passes sanity testing, merged to next |
|
merged to master |
xylar
added a commit
to xylar/compass
that referenced
this pull request
Jun 4, 2024
This merge updates the E3SM-Project submodule from [31e0924](https://github.com/E3SM-Project/E3SM/tree/31e0924) to [8939709](https://github.com/E3SM-Project/E3SM/tree/8939709). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/E3SM#6263 - [ ] (ocn) E3SM-Project/E3SM#6310 - [ ] (fwk) E3SM-Project/E3SM#6427 - [ ] (ocn) E3SM-Project/E3SM#6397 - [ ] (ocn) E3SM-Project/E3SM#6306 - [ ] (ocn) E3SM-Project/E3SM#6454
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just updates the metadata that will be produced in files that contain the MPAS mesh.
The description of these two variables has been updated to help developers (and users) better understand what they mean.