-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update descriptions of dcEdge and dvEdge #99
Update descriptions of dcEdge and dvEdge #99
Conversation
@mark-petersen, @proteanplanet, @matthewhoffman, as representatives form each affected component, could you let me know if you're okay with these changes to the descriptions of <var name="dvEdge" type="real" dimensions="nEdges" units="m"
description="The great circle distance between vertices bordering a given edge. It is the length of the edge on the primal mesh."
/>
<var name="dcEdge" type="real" dimensions="nEdges" units="m"
description="The great circle distance between cell centers bordering a given edge. It is the length of the edge on the dual mesh."
/> |
0c20d61
to
a4ea7f9
Compare
@xylar , thanks for tackling this. If we are adjusting these definitions, I would prefer some additional elaboration: dvEdge: dcEdge |
The second one should be "dual", rather than "primal", right? |
Good point about planar vs. spherical. |
Yes, oops, good catch. Copy-and-paste error. :) |
@matthewhoffman, could you take a careful look at the update I just made? I want to make sure it's what you wanted. |
Taking @mark-petersen off as he's away. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xylar , I read it carefully out loud twice, and it looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you.
I need to update the respective E3SM namelist files using https://github.com/MPAS-Dev/MPAS-Tools/blob/master/source_code_processing/e3sm_namelist_file_generator/generate_e3sm_namelist_files.py |
Never mind, there's nothing to update with |
The existing descriptions were not clear to developers.
615eb91
to
802bac7
Compare
Closing in favor of E3SM-Project#6427 |
The existing descriptions were not clear to developers.