-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BC and POM in coarse mode, plus associated chemistry mechanism #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new chemical mechanism is needed for MAM4 with resuspension, since the code adds new chemical species in the coarse mode aerosol. This update does the following: - Adds the chemistry mechanism files (produced by campp) into the source code as the trop_mam4_resus package. - Implements trop_mam4_resus in configure scripts. - Adds cases to if-statements that depend on the chemistry package in use, where needed. These changes are needed in order to be able to run the code introduced in PR #416 without a user-provided chemical mechanism file. The new configuration can be turned on by using the CAM_CONFIG_OPTS options "-chem trop_mam4" and "-rain_evap_to_coarse_aero" in combination. [BFB] [FCC] AG-138
After recent updates to the modal aeroso treatment, compsets using the (now deprecated) bulk aerosol treatment failed to build on some machines. This PR fixes the bugs that caused these failures. [BFB] Fixes #545
Merge branch 'susburrows/atm/add-coarse-bc-pom-chem-mech' into singhbalwinder/atm/add-bc-pom-coarse-mode Chemical mechanism added to code base so that user doesn't need to provide a chemical mechanism input file in order to use new aerosol microphysics with resuspension. [BFB] [FCC]
In testing with IBM compiler on cetus, the code (lines 5170-5175) in ./components/cam/src/chemistry/modal_aero/modal_aero_amicphys.F90 name_gas = '???' name_aerpfx = '???' name_aer = '???' name_aercw = '???' name_num = '???' name_numcw = '???' generates 1515-010 (S) String is missing a closing delimiter. Closing delimiter assumed at end of line. Changing these to name_gas = "???" name_aerpfx = "???" name_aer = "???" name_aercw = "???" name_num = "???" name_numcw = "???" allows compilation of cam to complete. Fixes #576 AG-138
@rljacob @yjinho @singhbalwinder : Here is the new PR with all the related changes rolled into one branch. I will close the old PRs now (which this replaces). |
This was referenced Dec 22, 2015
susburrows
added a commit
that referenced
this pull request
Dec 23, 2015
…#581) Add BC and POM in coarse mode, plus associated chemistry mechanism This PR adds BC and POM in the 3rd mode (coarse) of MAM3 and MAM4 chemistry packages, plus the code for the associated chemistry mechanism. To run the model in this configuration, user has to configure the model using "rain_evap_to_coarse_aero" option. This option will act as a CPP directive where turning this on would add BC and POM into the coarse mode of MAM3 or MAM4 chemistry packages. A new chemical mechanism is also needed for MAM4 with resuspension, which includes these new chemical species in the coarse mode aerosol. This update therefore does the following: Adds the chemistry mechanism files (produced by campp) into the source code as the trop_mam4_resus package. Implements trop_mam4_resus in configure scripts. Adds cases to if-statements that depend on the chemistry package in use, where needed. The new configuration (MAM4 + resuspension) can be turned on by using the CAM_CONFIG_OPTS options "-chem trop_mam4" and "-rain_evap_to_coarse_aero" in combination. A new namelist option "mam_amicphys_optaa_out" is added to control the invocation of amicphys codes. This PR also fixes a bug in the chemistry preprocessor and a bug in RtmMod.F90 file and incorporates other fixes that were identified during integration testing of this branch. Fixes #484 Fixes #545 Fixes #576 [BFB] [NML] [FCC] AG-138
susburrows
added a commit
that referenced
this pull request
Dec 23, 2015
This PR adds BC and POM in the 3rd mode (coarse) of MAM3 and MAM4 chemistry packages, plus the code for the associated chemistry mechanism. To run the model in this configuration, the user has to configure the model using the "rain_evap_to_coarse_aero" option. This option will act as a CPP directive where turning this on would add BC and POM into the coarse mode of MAM3 or MAM4 chemistry packages. A new chemical mechanism is also needed for MAM4 with resuspension, which includes these new chemical species in the coarse mode aerosol. This update therefore does the following: - Adds the chemistry mechanism files (produced by campp) into the source code as the trop_mam4_resus package. - Implements trop_mam4_resus in configure scripts. - Adds cases to if-statements that depend on the chemistry package in use, where needed. The new configuration (MAM4 + resuspension) can be turned on by using the CAM_CONFIG_OPTS options "-chem trop_mam4" and "-rain_evap_to_coarse_aero" in combination. A new namelist option "mam_amicphys_optaa_out" is added to control the invocation of amicphys codes. This PR also fixes a bug in the chemistry preprocessor and a bug in RtmMod.F90 file and incorporates other fixes that were identified during integration testing of this branch. Fixes #484 Fixes #545 Fixes #576 [BFB] [NML] [FCC] AG-138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Atmosphere
BFB
PR leaves answers BFB
bug fix PR
NML
Stealth
PR has feature which, if turned on, could change climate. fka FCC
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds BC and POM in the 3rd mode (coarse) of MAM3 and MAM4
chemistry packages, plus the code for the associated chemistry mechanism.
To run the model in this configuration, the user
has to configure the model using the "rain_evap_to_coarse_aero" option.
This option will act as a CPP directive where turning this on would
add BC and POM into the coarse mode of MAM3 or MAM4 chemistry
packages.
A new chemical mechanism is also needed for MAM4 with resuspension, which includes these new chemical species in the coarse mode aerosol. This update therefore does the following:
The new configuration (MAM4 + resuspension) can be turned on by using the CAM_CONFIG_OPTS
options "-chem trop_mam4" and "-rain_evap_to_coarse_aero" in combination.
A new namelist option "mam_amicphys_optaa_out" is added to control the invocation of amicphys codes.
This PR also fixes a bug in the chemistry preprocessor and a bug in RtmMod.F90 file and incorporates other fixes that were identified during integration testing of this branch.
Fixes #484
Fixes #545
Fixes #576
[BFB]
[NML]
[FCC]
AG-138