Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BC and POM in coarse mode, plus associated chemistry mechanism #581

Merged
merged 5 commits into from
Dec 23, 2015

Conversation

susburrows
Copy link
Contributor

This PR adds BC and POM in the 3rd mode (coarse) of MAM3 and MAM4
chemistry packages, plus the code for the associated chemistry mechanism.

To run the model in this configuration, the user
has to configure the model using the "rain_evap_to_coarse_aero" option.
This option will act as a CPP directive where turning this on would
add BC and POM into the coarse mode of MAM3 or MAM4 chemistry
packages.

A new chemical mechanism is also needed for MAM4 with resuspension, which includes these new chemical species in the coarse mode aerosol. This update therefore does the following:

  • Adds the chemistry mechanism files (produced by campp) into the source code as the trop_mam4_resus package.
  • Implements trop_mam4_resus in configure scripts.
  • Adds cases to if-statements that depend on the chemistry package in use, where needed.

The new configuration (MAM4 + resuspension) can be turned on by using the CAM_CONFIG_OPTS
options "-chem trop_mam4" and "-rain_evap_to_coarse_aero" in combination.

A new namelist option "mam_amicphys_optaa_out" is added to control the invocation of amicphys codes.

This PR also fixes a bug in the chemistry preprocessor and a bug in RtmMod.F90 file and incorporates other fixes that were identified during integration testing of this branch.

Fixes #484
Fixes #545
Fixes #576

[BFB]
[NML]
[FCC]
AG-138

A new chemical mechanism is needed for MAM4 with resuspension, since
the code adds new chemical species in the coarse mode aerosol.  This
update does the following:

- Adds the chemistry mechanism files (produced by campp) into the
  source code as the trop_mam4_resus package.
- Implements trop_mam4_resus in configure scripts.
- Adds cases to if-statements that depend on the chemistry package in
  use, where needed.

These changes are needed in order to be able to run the code
introduced in PR #416 without a user-provided chemical mechanism file.
The new configuration can be turned on by using the CAM_CONFIG_OPTS
options "-chem trop_mam4" and "-rain_evap_to_coarse_aero" in
combination.

[BFB]
[FCC]
AG-138
After recent updates to the modal aeroso treatment, compsets using the
(now deprecated) bulk aerosol treatment failed to build on some
machines.  This PR fixes the bugs that caused these failures.

[BFB]
Fixes #545
Merge branch 'susburrows/atm/add-coarse-bc-pom-chem-mech' into
singhbalwinder/atm/add-bc-pom-coarse-mode

Chemical mechanism added to code base so that user doesn't need to
provide a chemical mechanism input file in order to use new
aerosol microphysics with resuspension.

[BFB]
[FCC]
In testing with IBM compiler on cetus, the code (lines 5170-5175) in
./components/cam/src/chemistry/modal_aero/modal_aero_amicphys.F90

  name_gas    = '???'
  name_aerpfx = '???'
  name_aer    = '???'
  name_aercw  = '???'
  name_num    = '???'
  name_numcw  = '???'
generates

  1515-010 (S) String is missing a closing delimiter.  Closing delimiter assumed at end of line.

Changing these to

  name_gas    = "???"
  name_aerpfx = "???"
  name_aer    = "???"
  name_aercw  = "???"
  name_num    = "???"
  name_numcw  = "???"
allows compilation of cam to complete.

Fixes #576
AG-138
@susburrows susburrows added duplicate Atmosphere bug fix PR BFB PR leaves answers BFB NML Stealth PR has feature which, if turned on, could change climate. fka FCC labels Dec 22, 2015
@susburrows susburrows added this to the v1.0 Alpha milestone Dec 22, 2015
@susburrows susburrows self-assigned this Dec 22, 2015
@susburrows
Copy link
Contributor Author

This PR replaces #416 (which was merged to master then reverted), #539 and #545 (which are fixes to this branch and have been added to the branch here).

@susburrows
Copy link
Contributor Author

@rljacob @yjinho @singhbalwinder : Here is the new PR with all the related changes rolled into one branch. I will close the old PRs now (which this replaces).

susburrows added a commit that referenced this pull request Dec 23, 2015
…#581)

Add BC and POM in coarse mode, plus associated chemistry mechanism

This PR adds BC and POM in the 3rd mode (coarse) of MAM3 and MAM4
chemistry packages, plus the code for the associated chemistry mechanism.

To run the model in this configuration, user
has to configure the model using "rain_evap_to_coarse_aero" option.
This option will act as a CPP directive where turning this on would
add BC and POM into the coarse mode of MAM3 or MAM4 chemistry
packages.

A new chemical mechanism is also needed for MAM4 with resuspension,
which includes these new chemical species in the coarse mode
aerosol. This update therefore does the following:

Adds the chemistry mechanism files (produced by campp) into the source
code as the trop_mam4_resus package.  Implements trop_mam4_resus in
configure scripts.  Adds cases to if-statements that depend on the
chemistry package in use, where needed.  The new configuration (MAM4 +
resuspension) can be turned on by using the CAM_CONFIG_OPTS options
"-chem trop_mam4" and "-rain_evap_to_coarse_aero" in combination.

A new namelist option "mam_amicphys_optaa_out" is added to control the
invocation of amicphys codes.

This PR also fixes a bug in the chemistry preprocessor and a bug in
RtmMod.F90 file and incorporates other fixes that were identified
during integration testing of this branch.

Fixes #484
Fixes #545
Fixes #576

[BFB]
[NML]
[FCC]
AG-138
@susburrows susburrows merged commit 66f8585 into master Dec 23, 2015
susburrows added a commit that referenced this pull request Dec 23, 2015
This PR adds BC and POM in the 3rd mode (coarse) of MAM3 and MAM4
chemistry packages, plus the code for the associated chemistry
mechanism.

To run the model in this configuration, the user has to configure the
model using the "rain_evap_to_coarse_aero" option.  This option will
act as a CPP directive where turning this on would add BC and POM into
the coarse mode of MAM3 or MAM4 chemistry packages.

A new chemical mechanism is also needed for MAM4 with resuspension,
which includes these new chemical species in the coarse mode
aerosol. This update therefore does the following:

- Adds the chemistry mechanism files (produced by campp) into the
source code as the trop_mam4_resus package.

- Implements trop_mam4_resus in configure scripts.

- Adds cases to if-statements that depend on the chemistry package in
use, where needed.

The new configuration (MAM4 + resuspension) can be
turned on by using the CAM_CONFIG_OPTS options "-chem trop_mam4" and
"-rain_evap_to_coarse_aero" in combination.

A new namelist option "mam_amicphys_optaa_out" is added to control the
invocation of amicphys codes.

This PR also fixes a bug in the chemistry preprocessor and a bug in
RtmMod.F90 file and incorporates other fixes that were identified
during integration testing of this branch.

Fixes #484
Fixes #545
Fixes #576

[BFB]
[NML]
[FCC]
AG-138
@susburrows susburrows deleted the singhbalwinder/atm/add-bc-pom-coarse-mode branch December 23, 2015 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Atmosphere BFB PR leaves answers BFB bug fix PR NML Stealth PR has feature which, if turned on, could change climate. fka FCC
Projects
None yet
1 participant