Add bc and pom in the coarse mode of the MAM3/MAM4 chem pkgs #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds BC and POM in the 3rd mode (coarse) of MAM3 and MAM4 chemistry packages. To run the model is this configuration, user has to configure the model using "rain_evap_to_coarse_aero" option. This option will act as a CPP directive where turning this on would add BC and POM into the coarse mode of MAM3 or MAM4 chemistry packages. This commit also fixes a bug in the chemistry preprocessor. [BFB]
|
This is a part of the polar mods, the design document for which is here: https://acme-climate.atlassian.net/wiki/display/AMD/A5+Polar+Mods+Design+Document |
This commit adds a new file modal_aero_amicphys.F90 and modify associated codes. A new namelist option "mam_amicphys_optaa" is added to control the invokation of this code. This peice of code is invoked when "mam_amicphys_optaa" is set to 1 (default is 0). Fixes #484
susburrows
added a commit
that referenced
this pull request
Nov 30, 2015
…ows/atm/atm_integration (PR #416) Add bc and pom in the coarse mode of the MAM3/MAM4 chem pkgs This commit adds BC and POM in the 3rd mode (coarse) of MAM3 and MAM4 chemistry packages. To run the model is this configuration, user has to configure the model using "rain_evap_to_coarse_aero" option. This option will act as a CPP directive where turning this on would add BC and POM into the coarse mode of MAM3 or MAM4 chemistry packages. Another option "mam_amicphys_optaa_out" is added to control the invocation of amicphys codes. This commit also fixes a bug in the chemistry preprocessor and a bug in RtmMod.F90 file. Fixes #484 [BFB] [NML] [FCC] AG-138
susburrows
added a commit
that referenced
this pull request
Dec 8, 2015
…#416) This commit adds BC and POM in the 3rd mode (coarse) of MAM3 and MAM4 chemistry packages. To run the model is this configuration, user has to configure the model using "rain_evap_to_coarse_aero" option. This option will act as a CPP directive where turning this on would add BC and POM into the coarse mode of MAM3 or MAM4 chemistry packages. Another option "mam_amicphys_optaa_out" is added to control the invocation of amicphys codes. This commit also fixes a bug in the chemistry preprocessor and a bug in RtmMod.F90 file. Fixes #484 [BFB] [NML] [FCC] AG-138 Conflicts: components/cam/src/chemistry/modal_aero/modal_aero_initialize_data.F90
susburrows
added a commit
that referenced
this pull request
Dec 9, 2015
Add bc and pom in the coarse mode of the MAM3/MAM4 chem pkgs This commit adds BC and POM in the 3rd mode (coarse) of MAM3 and MAM4 chemistry packages. To run the model is this configuration, user has to configure the model using "rain_evap_to_coarse_aero" option. This option will act as a CPP directive where turning this on would add BC and POM into the coarse mode of MAM3 or MAM4 chemistry packages. Another option "mam_amicphys_optaa_out" is added to control the invocation of amicphys codes. This commit also fixes a bug in the chemistry preprocessor and a bug in RtmMod.F90 file. Fixes #484 [BFB] [NML] [FCC] AG-138
susburrows
added a commit
that referenced
this pull request
Dec 9, 2015
A new chemical mechanism is needed for MAM4 with resuspension, since the code adds new chemical species in the coarse mode aerosol. This update does the following: - Adds the chemistry mechanism files (produced by campp) into the source code as the trop_mam4_resus package. - Implements trop_mam4_resus in configure scripts. - Adds cases to if-statements that depend on the chemistry package in use, where needed. These changes are needed in order to be able to run the code introduced in PR #416 without a user-provided chemical mechanism file. The new configuration can be turned on by using the CAM_CONFIG_OPTS options "-chem trop_mam4" and "-rain_evap_to_coarse_aero" in combination. [BFB] [FCC] AG-138
yjinho
added a commit
that referenced
this pull request
Dec 11, 2015
#539) A new chemical mechanism is needed for MAM4 with resuspension, since the code adds new chemical species in the coarse mode aerosol. This update does the following: Adds the chemistry mechanism files (produced by campp) into the source code as the trop_mam4_resus package. Implements trop_mam4_resus in configure scripts. Adds cases to if-statements that depend on the chemistry package in use, where needed. These changes are needed in order to be able to run the code introduced in PR #416 without a user-provided chemical mechanism file. The new configuration can be turned on by using the CAM_CONFIG_OPTS options "-chem trop_mam4" and "-rain_evap_to_coarse_aero" in combination. [BFB] [FCC] AG-138 Conflicts: components/cam/bld/config_files/definition.xml components/cam/bld/configure components/cam/src/physics/cam/modal_aer_opt.F90 components/cam/src/physics/cam/nucleate_ice.F90 components/cam/src/physics/cam/phys_control.F90
This was referenced Dec 11, 2015
yjinho
added a commit
that referenced
this pull request
Dec 11, 2015
Updates build-nemalist in cam [BFB]
susburrows
added a commit
that referenced
this pull request
Dec 21, 2015
susburrows
added a commit
that referenced
this pull request
Dec 22, 2015
This reverts commit 0142d9e.
susburrows
added a commit
that referenced
this pull request
Dec 22, 2015
…#416) Merge version of branch that is updated with commit to fix error in bulk aerosol treatment that caused build failures (PR #547). After merge of original branch for PR #416, compsets using the prescribed aerosols / bulk aerosol treatment failed to build on some machines. This merge fixes the bugs that caused these failures. [BFB] Fixes #545
susburrows
added a commit
that referenced
this pull request
Dec 22, 2015
|
@rljacob , since I've reverted this code, is it possible to re-open the PR? Or should I just make a new one? Also, there were some additional fixes that I identified / implemented after originally merging this, for which I opened separate PRs (#539 and #545). I've now merged those changes to the same branch and could merge the entire set of changes in one bundle this time around. |
|
I don't see a "re-open merged PR" option. You'll probably just need to make a new PR for that same branch. Maybe @douglasjacobsen knows. |
|
I couldn't find one either. I'll make a new PR. |
|
Make a note that it replaces this PR (which will make a link). Do the same for any other new PR's needed. |
jgfouca
added a commit
that referenced
this pull request
Jun 2, 2017
improve err by removing rundir files and recopying from sta rest dire… Remove files from the run directory and replace them from the sta rest directory improving the scope of the err test. Test suite: scripts_regression_tests.py, ERR.f09_g16.B1850 Test baseline: Test namelist changes: Test status: bit for bit Fixes #416 User interface changes?: Code review: @jgfouca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds BC and POM in the 3rd mode (coarse) of MAM3 and MAM4
chemistry packages. To run the model is this configuration, user
has to configure the model using "rain_evap_to_coarse_aero" option.
This option will act as a CPP directive where turning this on would
add BC and POM into the coarse mode of MAM3 or MAM4 chemistry
packages.
Another option "mam_amicphys_optaa_out" is added to control the invocation of amicphys codes.
This commit also fixes a bug in the chemistry preprocessor and a bug in RtmMod.F90 file.
Fixes #484
[BFB]
[NML]
[FCC]
AG-138